Skip to content

Rollup of 14 pull requests #130230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 34 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
736ab66
Don't suggest adding return type for closures with default return type
wafarm Aug 19, 2024
2ddcbca
Suggest the struct variant pattern syntax on usage of unit variant pa…
tunawasabi Aug 24, 2024
7ed9f94
Don't leave debug locations for constants sitting on the builder inde…
khuey Sep 6, 2024
f98ca32
Fix linking error when compiling for 32-bit watchOS
madsmtm Sep 7, 2024
713828d
Add test for S_OBJNAME and update test for LF_BUILDINFO cl and cmd for
nebulark Sep 6, 2024
4cecf42
Report the `note` when specified in `diagnostic::on_unimplemented`
FedericoBruzzone Sep 8, 2024
8f81597
Map `WSAEDQUOT` to `ErrorKind::FilesystemQuotaExceeded`
GrigorenkoPV Sep 10, 2024
49b3df9
Map `ERROR_CANT_RESOLVE_FILENAME` to `ErrorKind::FilesystemLoop`
GrigorenkoPV Sep 10, 2024
4198594
Clarify docs for std::collections
root-goblin Sep 1, 2024
180eace
these tests seem to work fine on i586 these days
RalfJung Aug 31, 2024
c40ee79
move float tests into their own dir
workingjubilee Sep 10, 2024
3daa951
enable and extend float-classify test
RalfJung Aug 31, 2024
e556c13
clean up internal comments about float semantics
RalfJung Aug 31, 2024
b44f1dd
update stdarch
RalfJung Aug 28, 2024
542a6c6
miri: support vector index arguments in simd_shuffle
RalfJung Sep 11, 2024
6eddbb7
Fix false positive with `missing_docs` and `#[test]`
ogoffart Sep 11, 2024
9566163
Make SearchPath::new public
Sep 11, 2024
5d456df
Use `#[doc(hidden)]` instead of `#[allow(missing_docs)]` on the const…
ogoffart Sep 11, 2024
cc34d64
Use `doc(hidden)` instead of `allow(missing_docs)` in the test harness
ogoffart Sep 11, 2024
41dc5d3
Stabilize `const_refs_to_static`
dingxiangfei2009 Aug 29, 2024
e6c3b67
Rollup merge of #129260 - wafarm:dont-suggest-closures, r=compiler-er…
workingjubilee Sep 11, 2024
47b5185
Rollup merge of #129520 - tunawasabi:suggest-adding-struct-pattern-sy…
workingjubilee Sep 11, 2024
027a105
Rollup merge of #129696 - RalfJung:stdarch, r=Amanieu
workingjubilee Sep 11, 2024
4cda52d
Rollup merge of #129759 - dingxiangfei2009:stabilize-const-refs-to-st…
workingjubilee Sep 11, 2024
16a1186
Rollup merge of #129835 - RalfJung:float-tests, r=workingjubilee
workingjubilee Sep 11, 2024
3a54e98
Rollup merge of #129866 - root-goblin:patch-1, r=workingjubilee
workingjubilee Sep 11, 2024
dfdc5b6
Rollup merge of #130052 - khuey:clear-dilocation-after-const-emission…
workingjubilee Sep 11, 2024
37e6ace
Rollup merge of #130077 - madsmtm:watchos-arm-unwind, r=workingjubilee
workingjubilee Sep 11, 2024
7a2b05f
Rollup merge of #130123 - FedericoBruzzone:master, r=compiler-errors
workingjubilee Sep 11, 2024
8b3e984
Rollup merge of #130156 - nebulark:test_buildinfo, r=jieyouxu
workingjubilee Sep 11, 2024
c4e2002
Rollup merge of #130206 - GrigorenkoPV:WSAEDQUOT, r=ChrisDenton
workingjubilee Sep 11, 2024
c60f562
Rollup merge of #130207 - GrigorenkoPV:ERROR_CANT_RESOLVE_FILENAME, r…
workingjubilee Sep 11, 2024
0b4c281
Rollup merge of #130219 - ogoffart:missing-docs-test, r=Urgau
workingjubilee Sep 11, 2024
2f4edab
Rollup merge of #130221 - vetleras:pub_search_path_new, r=chenyukang
workingjubilee Sep 11, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use doc(hidden) instead of allow(missing_docs) in the test harness
So that it doesn't fail with `forbid(missing_docs)`

Fixes #130218
  • Loading branch information
ogoffart committed Sep 11, 2024
commit cc34d64c511feaf576854797fc291e03f5f275a7
6 changes: 3 additions & 3 deletions compiler/rustc_builtin_macros/src/test_harness.rs
Original file line number Diff line number Diff line change
Expand Up @@ -326,8 +326,8 @@ fn mk_main(cx: &mut TestCtxt<'_>) -> P<ast::Item> {
let main_attr = ecx.attr_word(sym::rustc_main, sp);
// #[coverage(off)]
let coverage_attr = ecx.attr_nested_word(sym::coverage, sym::off, sp);
// #[allow(missing_docs)]
let missing_docs_attr = ecx.attr_nested_word(sym::allow, sym::missing_docs, sp);
// #[doc(hidden)]
let doc_hidden_attr = ecx.attr_nested_word(sym::doc, sym::hidden, sp);

// pub fn main() { ... }
let main_ret_ty = ecx.ty(sp, ast::TyKind::Tup(ThinVec::new()));
Expand Down Expand Up @@ -357,7 +357,7 @@ fn mk_main(cx: &mut TestCtxt<'_>) -> P<ast::Item> {

let main = P(ast::Item {
ident: main_id,
attrs: thin_vec![main_attr, coverage_attr, missing_docs_attr],
attrs: thin_vec![main_attr, coverage_attr, doc_hidden_attr],
id: ast::DUMMY_NODE_ID,
kind: main,
vis: ast::Visibility { span: sp, kind: ast::VisibilityKind::Public, tokens: None },
Expand Down
1 change: 0 additions & 1 deletion compiler/rustc_span/src/symbol.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1236,7 +1236,6 @@ symbols! {
mir_unwind_unreachable,
mir_variant,
miri,
missing_docs,
mmx_reg,
modifiers,
module,
Expand Down
2 changes: 1 addition & 1 deletion tests/pretty/tests-are-sorted.pp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
fn a_test() {}
#[rustc_main]
#[coverage(off)]
#[allow(missing_docs)]
#[doc(hidden)]
pub fn main() -> () {
extern crate test;
test::test_main_static(&[&a_test, &m_test, &z_test])
Expand Down
4 changes: 3 additions & 1 deletion tests/ui/lint/lint-missing-doc-test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
//! on the generated test harness.

//@ check-pass
//@ compile-flags: --test -Dmissing_docs
//@ compile-flags: --test

#![forbid(missing_docs)]

#[test]
fn test() {}
Loading