generalize: track relevant info in cache key

[lcnr]

This was previously theoretically incomplete as we could incorrectly generalize as if the type was in an invariant context even though we're in a covariant one. Similar with the in_alias flag.

r? @compiler-errors

[lcnr]

@bors try @rust-timer queue

[rustbot]

changes to the core type system

cc @compiler-errors, @lcnr

[bors]

⌛ Trying commit 7a57a74 with merge 1cbbb1b...

[compiler-errors]

:0 good catch!

[compiler-errors]

r=me after perf

[bors]

☀️ Try build successful - checks-actions
Build commit: 1cbbb1b (1cbbb1b08c0fe67fe42c5fa65cecb6580e5805e5)

[rust-timer]

Finished benchmarking commit (1cbbb1b): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.4%, 1.1%]	14
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -3.1%, secondary 3.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.4%, 4.6%]	3
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.1%	[-3.1%, -3.1%]	1

Cycles

Results (secondary -4.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.7%	[-5.6%, -4.3%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 760.197s -> 757.791s (-0.32%)
Artifact size: 341.23 MiB -> 341.23 MiB (0.00%)

[compiler-errors]

necessary for soundness and only a secondary regression :)

@bors r+

[bors]

📌 Commit 7a57a74 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7a57a74 with merge 5a2dd7d...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5a2dd7d to master...

[rust-timer]

Finished benchmarking commit (5a2dd7d): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[0.4%, 1.3%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-4.6%, -2.6%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -17.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-17.7%	[-19.0%, -16.6%]	6
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 755.32s -> 757.068s (0.23%)
Artifact size: 341.31 MiB -> 341.32 MiB (0.00%)

[lqd]

@rustbot label: +perf-regression-triaged

necessary for soundness and only a secondary regression :)

Only in icounts. Also, ctfe-stress is noise.