Stop unnecessarily taking GenericPredicates by &self

[compiler-errors]

This results in overcapturing in edition 2024, and is unnecessary since GenericPredicates: Copy.

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit cc96efd with merge 924db9a...

[estebank]

r=me if perf positive

[bors]

☀️ Try build successful - checks-actions
Build commit: 924db9a (924db9a3163c06def63c5132ee96fb7f39fa9389)

[rust-timer]

Finished benchmarking commit (924db9a): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[2.4%, 7.4%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.8%, -2.1%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 760.99s -> 760.241s (-0.10%)
Artifact size: 336.87 MiB -> 336.90 MiB (0.01%)

[compiler-errors]

@bors r=estebank

[bors]

📌 Commit cc96efd has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit cc96efd with merge 019b892...

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   5 | >>> FROM centos:7
   6 |     
   7 |     WORKDIR /build
--------------------
ERROR: failed to solve: centos:7: failed to resolve source metadata for docker.io/library/centos:7: failed to do request: Head "https://registry-1.docker.io/v2/library/centos/manifests/7": net/http: TLS handshake timeout (did you mean centos?)
##[error]Process completed with exit code 1.
Post job cleanup.

[bors]

💔 Test failed - checks-actions

[compiler-errors]

@bors retry

[bors]

⌛ Testing commit cc96efd with merge 7347f8e...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 7347f8e to master...

[rust-timer]

Finished benchmarking commit (7347f8e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.3%, -0.3%]	1

Max RSS (memory usage)

Results (primary 1.1%, secondary 0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.5%, 1.8%]	2
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[0.5%, 1.8%]	2

Cycles

Results (primary 0.5%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 762.097s -> 762.637s (0.07%)
Artifact size: 339.28 MiB -> 339.23 MiB (-0.01%)