Skip to content

Check no pointee attribute pos #128571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Check no pointee attribute pos #128571

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
25e64cd
adds error emition when `#[pointee]` used incorrectly
gangov Aug 2, 2024
4058d49
adds tests
gangov Aug 2, 2024
04e2511
adds a missing `:`
gangov Aug 2, 2024
be3804d
lints
gangov Aug 2, 2024
36b9c9e
tidy
gangov Aug 2, 2024
9914733
adds smart_pointer attr
gangov Aug 2, 2024
0895bfa
lints the stderr file
gangov Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
adds error emition when #[pointee] used incorrectly
  • Loading branch information
@gangov
gangov committed Aug 2, 2024
commit 25e64cd95f21bac4e4cb15dc93f8bfea063a43e0
6 changes: 6 additions & 0 deletions compiler/rustc_passes/src/check_attr.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
self.check_rustc_std_internal_symbol(attr, span, target)
}
[sym::naked] => self.check_naked(hir_id, attr, span, target, attrs),
[sym:pointee] => self.check_pointee(hir_id, attr, span, target, attrs),
[sym::rustc_never_returns_null_ptr] => {
self.check_applied_to_fn_or_method(hir_id, attr, span, target)
}
Expand Down Expand Up @@ -2279,6 +2280,11 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
self.abort.set(true);
}
}

/// Check if `#[pointee]` has been applied to a function
fn check_pointee(&self, hir_id: HirId, attr: &Attribute, span: Span, target: Target) {
self.check_applied_to_fn_or_method(hir_id, attr, span, target)
}
}

impl<'tcx> Visitor<'tcx> for CheckAttrVisitor<'tcx> {
Expand Down