[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! #128393

jieyouxu · 2024-07-30T13:17:06Z

r? @ghost

try-job: x86_64-mingw

jieyouxu · 2024-07-30T13:17:33Z

@bors try

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! r? `@ghost` try-job: x86_64-mingw

bors · 2024-07-30T13:18:44Z

⌛ Trying commit 7cca04c with merge 26c80d6...

jieyouxu · 2024-07-30T14:39:51Z

@bors try

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! r? `@ghost` try-job: x86_64-mingw

bors · 2024-07-30T14:41:03Z

⌛ Trying commit b5df083 with merge 8e06142...

rust-log-analyzer · 2024-07-30T15:31:19Z

The job x86_64-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Updating files:  99% (48808/48872)
Updating files:  99% (48855/48872)
Updating files: 100% (48872/48872)
Updating files: 100% (48872/48872), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format='%H'
'26c80d65ae32553174f0132791721a0755d43b45'
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
---- [run-make] tests\run-make\symbol-visibility stdout ----

error: run-make test failed: could not build `rmake.rs` recipe
status: exit code: 1
command: "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2\\bin\\rustc.exe" "-o" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\symbol-visibility\\rmake.exe" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools-bin" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools\\x86_64-pc-windows-gnu\\release\\deps" "-Ldependency=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools\\release\\deps" "--extern" "run_make_support=C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools-bin\\librun_make_support.rlib" "--edition=2021" "C:\\a\\rust\\rust\\tests\\run-make\\symbol-visibility\\rmake.rs" "-Dunused_must_use"
--- stderr -------------------------------
warning: unused import: `is_windows`
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:12:52
   |
   |
12 | use run_make_support::{bin_name, dynamic_lib_name, is_windows, llvm_readobj, regex, rustc};
   |
   = note: `#[warn(unused_imports)]` on by default

error[E0277]: `SymbolCheckType` doesn't implement `std::fmt::Debug`
error[E0277]: `SymbolCheckType` doesn't implement `std::fmt::Debug`
##[error]   --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:156:46
    |
156 |         eprintln!("symbol_check_type: {:?}", symbol_check_type);
    |                                              ^^^^^^^^^^^^^^^^^ `SymbolCheckType` cannot be formatted using `{:?}`
    = help: the trait `std::fmt::Debug` is not implemented for `SymbolCheckType`
    = help: the trait `std::fmt::Debug` is not implemented for `SymbolCheckType`
    = note: add `#[derive(Debug)]` to `SymbolCheckType` or manually `impl std::fmt::Debug for SymbolCheckType`
    = note: this error originates in the macro `$crate::format_args_nl` which comes from the expansion of the macro `eprintln` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider annotating `SymbolCheckType` with `#[derive(Debug)]`
174 + #[derive(Debug)]
175 | enum SymbolCheckType {
    |


warning: unused variable: `exe_name`
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:17:9
   |
17 |     let exe_name = bin_name("an_executable");
   |         ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_exe_name`
   = note: `#[warn(unused_variables)]` on by default

warning: variable does not need to be mutable
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:15:9
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:15:9
   |
15 |     let mut cdylib_name = dynamic_lib_name("a_cdylib");
   |         |
   |         help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default
   = note: `#[warn(unused_mut)]` on by default

warning: variable does not need to be mutable
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:16:9
   |
16 |     let mut rdylib_name = dynamic_lib_name("a_rust_dylib");
   |         |
   |         help: remove this `mut`

warning: variable does not need to be mutable
warning: variable does not need to be mutable
##[warning]  --> C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:18:9
   |
18 |     let mut combined_cdylib_name = dynamic_lib_name("combined_rlib_dylib");
   |         |
   |         help: remove this `mut`

error: aborting due to 1 previous error; 5 warnings emitted

rust-log-analyzer · 2024-07-30T16:28:47Z

The job x86_64-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Updating files:  98% (48285/48872)
Updating files:  99% (48384/48872)
Updating files: 100% (48872/48872)
Updating files: 100% (48872/48872), done.
branch 'try' set up to track 'origin/try'.
Switched to a new branch 'try'
[command]"C:\Program Files\Git\bin\git.exe" log -1 --format='%H'
'8e06142e30958c951ca820e7493de6c1f07489b0'
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
---
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
---- [run-make] tests\run-make\symbol-visibility stdout ----

error: rmake recipe failed to complete
status: exit code: 101
command: "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\symbol-visibility\\rmake.exe"
--- stderr -------------------------------
--- stderr -------------------------------
symbol_check_type: StrSymbol("public_c_function_from_cdylib")
matched_lines:
[]
thread 'main' panicked at C:\a\rust\rust\tests\run-make\symbol-visibility\rmake.rs:32:5:
assertion `left == right` failed

bors · 2024-07-30T16:28:53Z

💔 Test failed - checks-actions

bors · 2024-08-01T09:04:20Z

☔ The latest upstream changes (presumably #127060) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical added 2 commits July 30, 2024 21:04

rewrite symbol-visibility to rmake

f717130

invalid stdout_utf8 handling in run_make_support

1770150

jieyouxu marked this pull request as draft July 30, 2024 13:17

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024

Auto merge of rust-lang#128393 - jieyouxu:exp-pr-127060, r=<try>

26c80d6

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! r? `@ghost` try-job: x86_64-mingw

This comment was marked as outdated.

Sign in to view

[EXPERIMENTAL] why does this fail

b5df083

jieyouxu force-pushed the exp-pr-127060 branch from 7cca04c to b5df083 Compare July 30, 2024 14:39

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2024

Auto merge of rust-lang#128393 - jieyouxu:exp-pr-127060, r=<try>

8e06142

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! r? `@ghost` try-job: x86_64-mingw

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2024

jieyouxu closed this Aug 1, 2024

jieyouxu deleted the exp-pr-127060 branch August 1, 2024 10:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! #128393

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! #128393

Uh oh!

jieyouxu commented Jul 30, 2024 •

edited

Loading

Uh oh!

jieyouxu commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

This comment was marked as outdated.

jieyouxu commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

rust-log-analyzer commented Jul 30, 2024

Uh oh!

rust-log-analyzer commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

bors commented Aug 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

[EXPERIMENTAL] symbol-visibility: x86_64-mingw, what did you see?! #128393

[EXPERIMENTAL] symbol-visibility: x86_64-mingw, what did you see?! #128393

Uh oh!

Conversation

jieyouxu commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

This comment was marked as outdated.

jieyouxu commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

rust-log-analyzer commented Jul 30, 2024

Uh oh!

rust-log-analyzer commented Jul 30, 2024

Uh oh!

bors commented Jul 30, 2024

Uh oh!

bors commented Aug 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! #128393

[EXPERIMENTAL] `symbol-visibility`: `x86_64-mingw`, what did you see?! #128393

jieyouxu commented Jul 30, 2024 •

edited

Loading