Skip to content

codegen: do not set attributes on foreign function imports #128247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

codegen: do not set attributes on foreign function imports #128247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96e9134
declare imported functions with a nondescript signature
RalfJung Aug 18, 2024
dfcd0db
do not set the attributes quite as often
RalfJung Sep 4, 2024
a78c911
add foreign-vectorcall test
RalfJung Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add foreign-vectorcall test
  • Loading branch information
@RalfJung
RalfJung committed Sep 11, 2024
commit a78c911ecf11ae34715989bce30461e396e035b9
10 changes: 10 additions & 0 deletions tests/ui/extern/auxiliary/foreign-vectorcall.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// Make the aux build not use `dylib` to avoid https://github.com/rust-lang/rust/issues/130196
//@ no-prefer-dynamic
#![feature(abi_vectorcall)]
#![crate_type = "lib"]

#[no_mangle]
#[inline(never)]
pub extern "vectorcall" fn call_with_42(i: i32) {
assert_eq!(i, 42);
}
10 changes: 10 additions & 0 deletions tests/ui/extern/extern-vectorcall.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,19 @@
//@ run-pass
//@ aux-build:foreign-vectorcall.rs
//@ revisions: x64 x32
//@ [x64]only-x86_64
//@ [x32]only-x86

#![feature(abi_vectorcall)]

extern crate foreign_vectorcall;

// Import this as a foreign function, that's the code path we are interested in
// (LLVM has to do some name mangling here).
extern "vectorcall" {
fn call_with_42(i: i32);
}

trait A {
extern "vectorcall" fn test1(i: i32);
}
Expand All @@ -24,4 +33,5 @@ extern "vectorcall" fn test2(i: i32) {
fn main() {
<S as A>::test1(1);
test2(2);
unsafe { call_with_42(42) };
}
Loading