-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: clean up and fix ord violations in item sorting #128146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @orlp |
0de14c5
to
b61e159
Compare
Thanks a lot for the improvements! It's indeed much better. Just one nit in the commit message: it's |
b61e159
to
e00adaf
Compare
Based on e3fdafc with a few minor changes: - The name sorting function is changed to follow the [version sort] from the style guide - the `cmp` function is redesigned to more obviously make a partial order, by always return `cmp()` of the same variable as the `!=` above [version sort]: https://doc.rust-lang.org/nightly/style-guide/index.html#sorting Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
e00adaf
to
5384692
Compare
Good catch. I've fixed it. |
r=me once CI is green. |
@bors r=GuillaumeGomez |
It's blocking a release so let's increase the priority. @bors p=10 |
☀️ Test successful - checks-actions |
[experiment] Bump stage0 I don't think it's exactly clear what the status of rust-lang#128083 is and whether or not we need a backport. Try applying the first three commits now that rust-lang#128146 has merged to verify whether or not we need a backport.
Finished benchmarking commit (c1a6199): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.858s -> 772.173s (0.17%) |
@rustbot label +beta-nominated As I understand it, we need this in the beta compiler to be able to do the stage0 bump at #128083. That PR is failing at an ICE in 1.81.0-beta.1, which should be fixed by this. Since it is blocking a step in the release cycle, hopefully we can get this merged before the next dist run. @GuillaumeGomez please correct me if this isn't accurate. |
…mulacrum [beta] rustdoc: clean up and fix ord violations in item sorting Cherry-picks "rustdoc: clean up and fix ord violations in item sorting rust-lang#128146" to beta. r? `@Mark-Simulacrum`
No this is exactly as stated. |
Based on #128139 with a few minor changes:
cmp
function is redesigned to more obviously make a partial order, by always returncmp()
of the same variable as the!=
above