Skip to content

Migrate extern-diff-internal-name, extern-multiple-copies and extern-multiple-copies2 run-make tests to rmake #128102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2024
Merged

Migrate extern-diff-internal-name, extern-multiple-copies and extern-multiple-copies2 run-make tests to rmake #128102

merged 3 commits into from
Jul 25, 2024

Conversation

@Oneirical
Copy link
Contributor

Part of #121876 and the associated Google Summer of Code project.

Please try:

try-job: test-various

@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 23, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 23, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

@Kobzol Kobzol mentioned this pull request Jul 23, 2024
Closed
@Kobzol
Copy link
Member

Kobzol commented Jul 23, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 23, 2024
@bors
Auto merge of rust-lang#128102 - Oneirical:real-testate, r=<try>
857b521 
Migrate `extern-diff-internal-name`, `extern-multiple-copies` and `extern-multiple-copies2` `run-make` tests to rmake

Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).

Please try:

try-job: test-various
@bors
Copy link
Collaborator

bors commented Jul 23, 2024

⌛ Trying commit c575b26 with merge 857b521...

Kobzol
Kobzol reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if try job passes.

@Kobzol
Copy link
Member

Kobzol commented Jul 23, 2024

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned jieyouxu Jul 23, 2024
@bors
Copy link
Collaborator

bors commented Jul 23, 2024

☀️ Try build successful - checks-actions
Build commit: 857b521 (857b52167ad89f26cebb6aed141eb55527a769b3)

jieyouxu
jieyouxu reviewed Jul 23, 2024
View reviewed changes
jieyouxu
jieyouxu reviewed Jul 23, 2024
View reviewed changes
jieyouxu
jieyouxu reviewed Jul 23, 2024
View reviewed changes
@Oneirical
Copy link
Contributor Author

All ignores removed.

@Kobzol
Copy link
Member

Kobzol commented Jul 23, 2024

Thank you! Let's see if this also passes the whole test suite without the ignores.

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 23, 2024

📌 Commit 421619d has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2024
@bors
Copy link
Collaborator

bors commented Jul 25, 2024

⌛ Testing commit 421619d with merge 54be9ad...

@bors
Copy link
Collaborator

bors commented Jul 25, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 54be9ad to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 25, 2024
@bors bors merged commit 54be9ad into rust-lang:master Jul 25, 2024
@rustbot rustbot added this to the 1.82.0 milestone Jul 25, 2024
@bors bors mentioned this pull request Jul 25, 2024
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (54be9ad): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.337s -> 769.25s (-0.14%)
Artifact size: 328.89 MiB -> 328.92 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kobzol Kobzol Kobzol left review comments

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@Kobzol Kobzol

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects
Oxidizing run-make tests
Status: Done

Milestone

1.82.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Oneirical @rustbot @Kobzol @bors @rust-timer @jieyouxu