Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix display of logo "border" #127963

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix display of logo "border" #127963

merged 1 commit into from
Jul 19, 2024

Conversation

GuillaumeGomez
Copy link
Member

Before:

Screenshot from 2024-07-19 13-32-17

After:

Screenshot from 2024-07-19 13-37-46

r? @notriddle

@rustbot
Copy link
Collaborator

rustbot commented Jul 19, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 19, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 19, 2024
Merged
@notriddle
Copy link
Contributor

What does it look like when you mouse over the crate name after changing this?

@GuillaumeGomez
Copy link
Member Author

This:

image

Find it kinda nice. :)

@notriddle
Copy link
Contributor

If you're okay with it, then sure. Let's merge it.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 19, 2024

📌 Commit c75f775 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2024
@GuillaumeGomez
Copy link
Member Author

@bors rollup

@matthiaskrgr matthiaskrgr mentioned this pull request Jul 19, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@bors
Auto merge of rust-lang#127969 - matthiaskrgr:rollup-nhxmwhn, r=matth…
0cd01aa 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#112328 (Feat. adding ext that returns change_time)
 - rust-lang#126199 (Add `isqrt` to `NonZero<uN>`)
 - rust-lang#127856 (interpret: add sanity check in dyn upcast to double-check what codegen does)
 - rust-lang#127934 (Improve error when a compiler/library build fails in `checktools.sh`)
 - rust-lang#127960 (Cleanup dll/exe filename calculations in `run_make_support`)
 - rust-lang#127963 (Fix display of logo "border")
 - rust-lang#127967 (Disable run-make/split-debuginfo test for RISC-V 64)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1318ec0 into rust-lang:master Jul 19, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 19, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 19, 2024
@rust-timer
Unrolled build for rust-lang#127963
25a3e49 
Rollup merge of rust-lang#127963 - GuillaumeGomez:fix-logo-display, r=notriddle

Fix display of logo "border"

Before:

![Screenshot from 2024-07-19 13-32-17](https://github.com/user-attachments/assets/381bb9c8-0ae0-408b-8476-9785ef1b5fd4)

After:

![Screenshot from 2024-07-19 13-37-46](https://github.com/user-attachments/assets/19cdb71f-3912-4fcd-95de-99b9f86a8293)

r? `@notriddle`
@GuillaumeGomez GuillaumeGomez deleted the fix-logo-display branch July 19, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @rustbot @notriddle @bors