Skip to content

Discard MTWT & interner tables from TLD after they stop being useful. #12770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2014

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Mar 8, 2014

Sadly, this seems to make memory usage worse (unless Vec<T> makes it worse and this PR doesn't change that much, which is entirely possible).

@huonw
Copy link
Member

huonw commented Mar 9, 2014

Why are we doing this if it makes mem usage worse?

@eddyb
Copy link
Member Author

eddyb commented Mar 10, 2014

I've seen a 1.5GB trans peak, so it's possible this actually shaves off almost a couple hundred MB.
We need more testing for this, but my laptop can barely handle it anymore (sigh @pcwalton) and @cmr is busy.

@alexcrichton
Copy link
Member

ping, any results? Is this a pr that @cmr could bench specially for memory?

@emberian
Copy link
Member

I'm willing to do so now, with a rebase

@emberian
Copy link
Member

graph

bors added a commit that referenced this pull request Mar 19, 2014
Sadly, this seems to make memory usage worse (unless `Vec<T>` makes it worse and this PR doesn't change that much, which is entirely possible).
@bors bors merged commit c04d484 into rust-lang:master Mar 19, 2014
@eddyb eddyb deleted the drop-tld branch March 20, 2014 05:21
flip1995 pushed a commit to flip1995/rust that referenced this pull request May 17, 2024
…tion, r=llogiq

Add new lint `doc_lazy_continuation`

changelog: [`doc_lazy_continuation`]: add lint that warns on so-called "lazy paragraph continuations"

This is a follow-up for rust-lang#121659, since most cases of unintended block quotes are lazy continuations. The lint is designed to be more generally useful than that, though, because it will also catch unintended list items and unintended block quotes that didn't coincidentally hit a pulldown-cmark bug.

The second commit is the result of running `cargo dev dogfood --fix`, and manually fixing anything that seems wrong. NOTE: this lint's suggestions should never change the parser's interpretation of the markdown, but in many cases, it seems that doc comments in clippy were written without regard for this feature of Markdown (which, I suppose, is why this lint should exist).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants