Skip to content

Miri subtree update #127317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 4, 2024
Merged

Miri subtree update #127317

merged 17 commits into from
Jul 4, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 4, 2024

r? @ghost

adwinwhite and others added 17 commits July 1, 2024 21:52
@adwinwhite
add syscall dup()
ccc50b2
@bjorn3
Use the symbol_name query instead of trying to infer from the link_na…
18049b7 
…me attribute

This prevents the calculated name from going out of sync with
exported_symbols. It also avoids having to special case the panic_impl
lang item.
@RalfJung
Preparing for merge from rustc
3e44883
@RalfJung
Merge from rustc
cbea3d7
@bors
Auto merge of rust-lang#3727 - RalfJung:rustup, r=RalfJung
3ca56a3 
Rustup

To unblock rust-lang/miri#3688
@bors
Auto merge of rust-lang#3724 - bjorn3:use_symbol_name_query, r=RalfJung
4a7d29f 
Use the symbol_name query instead of trying to infer from the link_name attribute

This prevents the calculated name from going out of sync with exported_symbols. It also avoids having to special case the panic_impl lang item.

It also makes it easier to fix miri with rust-lang#127173.
@RalfJung
use let-else to avoid rightwards drift
c96bec1
@bors
Auto merge of rust-lang#3707 - adwinwhite:dup, r=RalfJung
ad1d8a8 
Add syscall `dup()` for unix target

Add support for `dup()` and `dup2()`.

Fixes rust-lang#3454
@TDecking
Implement the _mm256_zeroupper and _mm256_zeroall intrinsics
d982844
@bors
Auto merge of rust-lang#3726 - TDecking:vzero, r=RalfJung
b0d791d 
Implement the `_mm256_zeroupper` and `_mm256_zeroall` intrinsics

These two intrinsics were missing from the original implementation of the AVX intrinsics.
Fortunately their implementation is trivial.
Preparing for merge from rustc
5c2946a
Merge from rustc
d24bfd4
@bors
Auto merge of rust-lang#3731 - rust-lang:rustup-2024-07-04, r=saethlin
4a4a81a 
Automatic Rustup
@JoJoDeveloping
TB: Make FnEntry access on protected locations be a write under certa…
8ef2c6c 
…in circumstances
@JoJoDeveloping
Add UI test for protector end write semantics
0a86e79
@JoJoDeveloping
TB: protector end semantics never causes immediate UB
02bec40
@bors
Auto merge of rust-lang#3732 - JoJoDeveloping:tree-borrows-protector-…
a3460e2 
…end-write, r=RalfJung

TB: Refine protector end semantics

Tree Borrows has protector end tag semantics, namely that protectors ending cause a [special implicit read](https://perso.crans.org/vanille/treebor/diff.0.html) on all locations protected by that protector that have actually been accessed. See also rust-lang#3067.

While this is enough for ensuring protectors allow adding/reordering reads, it does not prove that one can reorder writes. For this, we need to make this stronger, by making this implicit read be a write in cases when there was a write to the location protected by that protector, i.e. if the permission is `Active`.

There is a test that shows why this behavior is necessary, see `tests/fail/tree_borrows/protector-write-lazy.rs`.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 4, 2024

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

RalfJung commented Jul 4, 2024

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Jul 4, 2024

📌 Commit a3460e2 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 4, 2024
@bors
Auto merge of rust-lang#127317 - RalfJung:miri-sync, r=RalfJung
e342327 
Miri subtree update

r? `@ghost`
@bors
Copy link
Collaborator

bors commented Jul 4, 2024

⌛ Testing commit a3460e2 with merge e342327...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jul 4, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 4, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Jul 4, 2024

Looks unrelated
@bors retry error: failed to remove file C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\release\cargo.exe

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024
@bors
Copy link
Collaborator

bors commented Jul 4, 2024

⌛ Testing commit a3460e2 with merge c422581...

@bors
Copy link
Collaborator

bors commented Jul 4, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing c422581 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2024
@bors bors merged commit c422581 into rust-lang:master Jul 4, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jul 4, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c422581): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.9% [1.9%, 1.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.7%, secondary -2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.7% [1.7%, 1.7%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-3.9%, -1.2%] 10
All ❌✅ (primary) 1.7% [1.7%, 1.7%] 1

Cycles

Results (secondary -9.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -9.6% [-9.9%, -9.4%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 742.325s -> 721.419s (-2.82%)
Artifact size: 328.23 MiB -> 328.24 MiB (0.00%)

@RalfJung RalfJung deleted the miri-sync branch July 5, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.81.0

Development

Successfully merging this pull request may close these issues.

9 participants

@RalfJung @rustbot @bors @rust-log-analyzer @rust-timer @adwinwhite @bjorn3 @TDecking @JoJoDeveloping