Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake #127006

Oneirical · 2024-06-26T20:25:50Z

Part of #121876 and the associated Google Summer of Code project.

cdylib-fewer-symbols demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time)

try-job: x86_64-gnu-distcheck
try-job: x86_64-msvc
try-job: aarch64-apple

rustbot · 2024-06-26T20:25:57Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-26T20:25:59Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

Kobzol · 2024-06-26T21:27:25Z

@bors try

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). `cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time) try-job: x86_64-msvc

bors · 2024-06-26T21:28:36Z

⌛ Trying commit d1b874b with merge e598dbf...

bors · 2024-06-26T22:59:30Z

☀️ Try build successful - checks-actions
Build commit: e598dbf (e598dbf17b1e7ec54bc220c387ae6ace93db098f)

Oneirical · 2024-06-27T13:48:29Z

Well, how cool is that? I think it's because llvm-readobj is more platform-agnostic than nm. FIXME statement removed.

tests/run-make/cdylib-fewer-symbols/rmake.rs

tests/run-make/extern-flag-pathless/rmake.rs

Kobzol · 2024-06-28T20:52:14Z

Thanks!

@bors r+ rollup=iffy

bors · 2024-06-28T20:52:17Z

📌 Commit 53a7aee has been approved by Kobzol

It is now in the queue for this repository.

bors · 2024-06-30T05:16:52Z

⌛ Testing commit 53a7aee with merge 08ce4db...

…bzol Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). `cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time) try-job: x86_64-msvc

bors · 2024-06-30T05:51:51Z

💔 Test failed - checks-actions

…bzol Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). `cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time) try-job: x86_64-msvc try-job: armhf-gnu try-job: aarch64-apple try-job: test-various

bors · 2024-07-06T06:05:26Z

⌛ Testing commit ffc06a4 with merge 1600f03...

bors · 2024-07-06T07:16:46Z

💔 Test failed - checks-actions

jieyouxu · 2024-07-06T09:18:24Z

@bors r-

Oneirical · 2024-07-09T18:32:25Z

@bors try (No privileges)
@rustbot review
Please retry, I think it will work now (I was printing all symbols, not only external symbols like nm -g does).

bors · 2024-07-09T18:32:27Z

@Oneirical: 🔑 Insufficient privileges: not in try users

Kobzol · 2024-07-09T19:39:53Z

@bors try

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). `cdylib-fewer-symbols` demands a Windows try-job. (Almost guaranteed to fail, but 7 years is a long time) try-job: x86_64-gnu-distcheck try-job: x86_64-msvc try-job: aarch64-apple

bors · 2024-07-09T19:41:58Z

⌛ Trying commit d447321 with merge 1f8750c...

bors · 2024-07-09T21:20:05Z

☀️ Try build successful - checks-actions
Build commit: 1f8750c (1f8750c4be84251450bf03f5fea390d8c3cbae7f)

jieyouxu · 2024-07-10T06:12:43Z

Thanks!
@bors r=@Kobzol

bors · 2024-07-10T06:12:49Z

📌 Commit d447321 has been approved by Kobzol

It is now in the queue for this repository.

bors · 2024-07-10T08:51:23Z

⌛ Testing commit d447321 with merge 0fdfb61...

bors · 2024-07-10T11:08:23Z

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 0fdfb61 to master...

rust-timer · 2024-07-10T14:16:33Z

Finished benchmarking commit (0fdfb61): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -4.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.3%	[-4.3%, -4.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.3%	[-4.3%, -4.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 704.785s -> 705.036s (0.04%)
Artifact size: 328.71 MiB -> 328.82 MiB (0.04%)

rustbot assigned jieyouxu Jun 26, 2024

Kobzol mentioned this pull request Jun 26, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

Oneirical force-pushed the holmes-the-detestive branch from d1b874b to 1e9d09d Compare June 27, 2024 13:47

Kobzol reviewed Jun 28, 2024

View reviewed changes

tests/run-make/cdylib-fewer-symbols/rmake.rs Outdated Show resolved Hide resolved

tests/run-make/extern-flag-pathless/rmake.rs Show resolved Hide resolved

Oneirical force-pushed the holmes-the-detestive branch from 1e9d09d to e96cc78 Compare June 28, 2024 20:44

Oneirical added 4 commits June 28, 2024 16:44

rewrite extern-flag-pathless to rmake

16df91b

rewrite silly-file-names to rmake

11ac258

rewrite metadata-dep-info to rmake

db21af1

rewrite cdylib-fewer-symbols to rmake

7c29298

Oneirical force-pushed the holmes-the-detestive branch from e96cc78 to 53a7aee Compare June 28, 2024 20:45

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024

This comment has been minimized.

Sign in to view

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 30, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2024

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024

rewrite symbols-include-type-name to rmake

d447321

Oneirical force-pushed the holmes-the-detestive branch from ffc06a4 to d447321 Compare July 9, 2024 18:31

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2024

bors merged commit 0fdfb61 into rust-lang:master Jul 10, 2024

rustbot added this to the 1.81.0 milestone Jul 10, 2024

bors mentioned this pull request Jul 10, 2024

Migrate symbol-visibility run-make test to rmake #127060

Merged

Uh oh!

Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006

Migrate extern-flag-pathless, silly-file-names, metadata-dep-info, cdylib-fewer-symbols and symbols-include-type-name run-make tests to rmake #127006

Uh oh!

Conversation

Oneirical commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 26, 2024

Uh oh!

rustbot commented Jun 26, 2024

Uh oh!

Kobzol commented Jun 26, 2024

Uh oh!

bors commented Jun 26, 2024

Uh oh!

bors commented Jun 26, 2024

Uh oh!

Oneirical commented Jun 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kobzol commented Jun 28, 2024

Uh oh!

bors commented Jun 28, 2024

Uh oh!

bors commented Jun 30, 2024

Uh oh!

This comment has been minimized.

bors commented Jun 30, 2024

Uh oh!

bors commented Jul 6, 2024

Uh oh!

This comment has been minimized.

bors commented Jul 6, 2024

Uh oh!

jieyouxu commented Jul 6, 2024

Uh oh!

Oneirical commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Jul 9, 2024

Uh oh!

Kobzol commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

bors commented Jul 9, 2024

Uh oh!

jieyouxu commented Jul 10, 2024

Uh oh!

bors commented Jul 10, 2024

Uh oh!

bors commented Jul 10, 2024

Uh oh!

bors commented Jul 10, 2024

Uh oh!

rust-timer commented Jul 10, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake #127006

Migrate `extern-flag-pathless`, `silly-file-names`, `metadata-dep-info`, `cdylib-fewer-symbols` and `symbols-include-type-name` `run-make` tests to rmake #127006

Oneirical commented Jun 26, 2024 •

edited

Loading

Oneirical commented Jun 27, 2024 •

edited

Loading

Oneirical commented Jul 9, 2024 •

edited

Loading