Skip to content

Add /etc/terminfo to the terminfo search paths #12656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2014

Conversation

Armavica
Copy link
Contributor

@Armavica Armavica commented Mar 2, 2014

According to /etc/terminfo/README,

This directory is for system-local terminfo descriptions. By default,
ncurses will search ${HOME}/.terminfo first, then /etc/terminfo (this
directory), then /lib/terminfo, and last not least /usr/share/terminfo.

@Armavica
Copy link
Contributor Author

Armavica commented Mar 2, 2014

r? @cmr

@sfackler
Copy link
Member

sfackler commented Mar 2, 2014

Is there any reason to not match ncurse's search order exactly?

@Armavica
Copy link
Contributor Author

Armavica commented Mar 2, 2014

You probably have a point.

@@ -46,8 +46,9 @@ pub fn get_dbpath_for_term(term: &str) -> Option<~Path> {
// /usr/share/terminfo is the de facto location, but it seems
// Ubuntu puts it in /lib/terminfo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be updated to say where this search order is pulled from.

bors added a commit that referenced this pull request Mar 2, 2014
According to `/etc/terminfo/README`,
```
This directory is for system-local terminfo descriptions. By default,
ncurses will search ${HOME}/.terminfo first, then /etc/terminfo (this
directory), then /lib/terminfo, and last not least /usr/share/terminfo.
```
@bors bors closed this Mar 2, 2014
@bors bors merged commit 9790460 into rust-lang:master Mar 2, 2014
@Armavica Armavica deleted the terminfo branch March 16, 2014 02:11
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 25, 2024
…b-site, r=xFrednet

Add 'Expand All' & 'Collapse All' to the website

changelog: Add 'Expand All' and 'Collapse All' buttons to the website.
Fixes rust-lang#12542

Desktop view:
![image](https://github.com/rust-lang/rust-clippy/assets/43732866/554d7782-352c-4705-83f0-1cbc809a3290)

Mobile view:
![image](https://github.com/rust-lang/rust-clippy/assets/43732866/2845fc9a-a9e8-4057-b7dd-a8a1dbf47290)

I did have some slight performance issues with lots of tabs being open. In the future it may be worth it to consider virtual scrolling. I'm not sure if this would allow ctrl+f finding on all the lints since the DOM won't contain the text of all the lints, just those that need to be immediately shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants