rustc: Better error when loading invalid libraries #12645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r=me once travis builds |
When the metadata format changes, old libraries often cause librustc to abort when reading their metadata. This should all change with the introduction of SVH markers, but the loader for crates should gracefully handle libraries without SVH markers still. This commit adds support for tripping fewer assertions when loading libraries by using maybe_get_doc when initially parsing metadata. It's still possible for some libraries to fall through the cracks, but this should deal with a fairly large number of them up front.
bors
added a commit
that referenced
this pull request
Mar 2, 2014
When the metadata format changes, old libraries often cause librustc to abort when reading their metadata. This should all change with the introduction of SVH markers, but the loader for crates should gracefully handle libraries without SVH markers still. This commit adds support for tripping fewer assertions when loading libraries by using maybe_get_doc when initially parsing metadata. It's still possible for some libraries to fall through the cracks, but this should deal with a fairly large number of them up front.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…n-target, r=flodiebold Ignore the `bin` artifact for `bench` targets Just like `test`. Fixes rust-lang#12645. I don't know how to test that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the metadata format changes, old libraries often cause librustc to abort
when reading their metadata. This should all change with the introduction of SVH
markers, but the loader for crates should gracefully handle libraries without
SVH markers still.
This commit adds support for tripping fewer assertions when loading libraries by
using maybe_get_doc when initially parsing metadata. It's still possible for
some libraries to fall through the cracks, but this should deal with a fairly
large number of them up front.