Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented May 30, 2024

This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs.

r? @jdno

try-job: dist-i686-msvc
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 30, 2024
@Kobzol Kobzol marked this pull request as draft May 30, 2024 13:36
@Kobzol Kobzol changed the title [CI] Add metric upload to DataDog [CI] Upload CI metrics to DataDog May 30, 2024
@Kobzol
Copy link
Member Author

Kobzol commented May 31, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2024
[CI] Upload CI metrics to DataDog

This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level.

r? `@jdno`
@bors
Copy link
Collaborator

bors commented May 31, 2024

⌛ Trying commit 608d825 with merge a73c014...

@bors
Copy link
Collaborator

bors commented May 31, 2024

☀️ Try build successful - checks-actions
Build commit: a73c014 (a73c014e5592c6bae0273f2486a00998080bf5c8)

@Kobzol Kobzol force-pushed the ci-datadog-metrics branch from 608d825 to ddae1fa Compare May 31, 2024 12:53
@Kobzol
Copy link
Member Author

Kobzol commented May 31, 2024

@bors try

@bors
Copy link
Collaborator

bors commented May 31, 2024

⌛ Trying commit ddae1fa with merge 95b2963...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2024
[CI] Upload CI metrics to DataDog

This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level.

r? `@jdno`
@bors
Copy link
Collaborator

bors commented May 31, 2024

☀️ Try build successful - checks-actions
Build commit: 95b2963 (95b29636b64ab75e3078e335957d3039fbfd452e)

@Kobzol Kobzol force-pushed the ci-datadog-metrics branch from ddae1fa to 8934848 Compare June 29, 2024 19:17
@Kobzol
Copy link
Member Author

Kobzol commented Jun 29, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2024
[CI] Upload CI metrics to DataDog

This PR tests integration of Datadog CI custom metrics. My goal is to take various useful statistics (like the duration of stage 1 build, stage 2 build, and test execution) that we already gather into `metrics.json` and upload them as [custom metrics](https://docs.datadoghq.com/continuous_integration/pipelines/custom_commands/) into Datadog, so that we can observe job duration on a more granular level.

r? `@jdno`
@bors
Copy link
Collaborator

bors commented Jun 29, 2024

⌛ Testing commit 2a2de5f with merge 38fb5df...

@Kobzol Kobzol force-pushed the ci-datadog-metrics branch 2 times, most recently from 2343ecd to 870653f Compare July 2, 2024 14:17
@Kobzol Kobzol marked this pull request as ready for review July 2, 2024 14:17
@Kobzol Kobzol changed the title [CI] Upload CI metrics to DataDog [CI] Upload average CPU utilization of CI jobs to DataDog Jul 2, 2024
@Kobzol
Copy link
Member Author

Kobzol commented Jul 2, 2024

@bors try

@bors
Copy link
Collaborator

bors commented Jul 2, 2024

⌛ Trying commit 870653f with merge b4cf8bf...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 2, 2024
[CI] Upload average CPU utilization of CI jobs to DataDog

This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs.

r? `@jdno`
@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol force-pushed the ci-datadog-metrics branch 3 times, most recently from f7acf06 to 95db961 Compare July 3, 2024 07:33
@bors
Copy link
Collaborator

bors commented Sep 26, 2024

💔 Test failed - checks-actions

@Kobzol
Copy link
Member Author

Kobzol commented Sep 27, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
[CI] Upload average CPU utilization of CI jobs to DataDog

This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs.

r? `@jdno`

try-job: dist-i686-msvc
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18
@bors
Copy link
Collaborator

bors commented Sep 27, 2024

⌛ Trying commit 477aae9 with merge 5616feb...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Sep 27, 2024

💔 Test failed - checks-actions

@Kobzol
Copy link
Member Author

Kobzol commented Sep 27, 2024

@bors try

@Kobzol
Copy link
Member Author

Kobzol commented Sep 27, 2024

@bors try

@bors
Copy link
Collaborator

bors commented Sep 27, 2024

⌛ Trying commit c1c0bd7 with merge 4d17f6e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
[CI] Upload average CPU utilization of CI jobs to DataDog

This PR adds a new CI step that uploads the average CPU utilization of the current GH job to Datadog. I want to add more metrics in follow-up PRs.

r? `@jdno`

try-job: dist-i686-msvc
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-18
@bors
Copy link
Collaborator

bors commented Sep 27, 2024

☀️ Try build successful - checks-actions
Build commit: 4d17f6e (4d17f6e633f4bd723a9903ca3c36314da04e2398)

@Kobzol
Copy link
Member Author

Kobzol commented Sep 27, 2024

Ok, it seems like now it finally works on Linux, Windows and macOS, phew..

@rustbot ready

CC @jdno

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2024
@jdno
Copy link
Member

jdno commented Oct 2, 2024

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Oct 2, 2024

📌 Commit c1c0bd7 has been approved by jdno

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2024
@bors
Copy link
Collaborator

bors commented Oct 2, 2024

⌛ Testing commit c1c0bd7 with merge 44722bd...

@bors
Copy link
Collaborator

bors commented Oct 2, 2024

☀️ Test successful - checks-actions
Approved by: jdno
Pushing 44722bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 2, 2024
@bors bors merged commit 44722bd into rust-lang:master Oct 2, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 2, 2024
@Kobzol Kobzol deleted the ci-datadog-metrics branch October 2, 2024 18:36
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (44722bd): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.3%, 3.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.7% [-1.0%, -0.4%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.7% [-2.7%, -2.7%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.583s -> 769.495s (-0.01%)
Artifact size: 341.50 MiB -> 341.49 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants