Skip to content

Winnow private method candidates instead of assuming any candidate of the right name will apply #125622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Winnow private method candidates instead of assuming any candidate of the right name will apply #125622

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e8df95
Manual rustfmt
oli-obk May 27, 2024
14f9c63
Show that it will pick up the entirely wrong function as a private ca…
oli-obk May 28, 2024
7d151fa
Turn a delayed bug back into a normal bug by winnowing private method…
oli-obk May 27, 2024
7894a11
Move tests to a more appropriate directory
oli-obk May 28, 2024
8189506
Give test a more useful name
oli-obk May 28, 2024
ffb1b2c
Add test description
oli-obk May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Give test a more useful name
  • Loading branch information
@oli-obk
oli-obk committed Jun 4, 2024
commit 81895065bb541b9e79f402d2446c1c83243b37d0
1 change: 0 additions & 1 deletion src/tools/tidy/src/issues.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,7 +2445,6 @@ ui/issues/issue-53300.rs
ui/issues/issue-53333.rs
ui/issues/issue-53348.rs
ui/issues/issue-53419.rs
ui/issues/issue-53498.rs
ui/issues/issue-53568.rs
ui/issues/issue-5358-1.rs
ui/issues/issue-53728.rs
Expand Down
2 changes: 1 addition & 1 deletion ...privacy/issue-53498.different_name.stderr → ...acy/ufc-method-call.different_name.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0599]: no function or associated item named `foo` found for struct `Foo<B>` in the current scope
--> $DIR/issue-53498.rs:21:27
--> $DIR/ufc-method-call.rs:21:27
|
LL | pub struct Foo<T>(T);
| ----------------- function or associated item `foo` not found for this struct
Expand Down
0 tests/ui/privacy/issue-53498.rs → tests/ui/privacy/ufc-method-call.rs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...s/ui/privacy/issue-53498.same_name.stderr → .../privacy/ufc-method-call.same_name.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error[E0624]: associated function `foo` is private
--> $DIR/issue-53498.rs:21:27
--> $DIR/ufc-method-call.rs:21:27
|
LL | fn foo() {}
| -------- private associated function defined here
Expand Down