Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 17, 2024

Part of #121876.

r? @jieyouxu

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 17, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2024

The run-make-support library was changed

cc @jieyouxu

Some changes occurred in run-make tests.

cc @jieyouxu

@GuillaumeGomez GuillaumeGomez force-pushed the migrate-rustdoc-scrape-examples-ordering branch from 80d0ceb to 272fc89 Compare May 17, 2024 12:04
@jieyouxu
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2024

📌 Commit 272fc89 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2024
@bors
Copy link
Collaborator

bors commented May 17, 2024

⌛ Testing commit 272fc89 with merge 550d1b4...

@bors
Copy link
Collaborator

bors commented May 17, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 550d1b4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 17, 2024
@bors bors merged commit 550d1b4 into rust-lang:master May 17, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 17, 2024
@GuillaumeGomez GuillaumeGomez deleted the migrate-rustdoc-scrape-examples-ordering branch May 17, 2024 16:16
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (550d1b4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.5% [-0.5%, -0.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.5% [-0.5%, -0.5%] 1

Cycles

Results (primary 2.6%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.6% [1.9%, 4.1%] 4
Regressions ❌
(secondary)
3.6% [1.6%, 5.1%] 4
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.9% [-4.2%, -1.3%] 5
All ❌✅ (primary) 2.6% [1.9%, 4.1%] 4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 667.526s -> 668.179s (0.10%)
Artifact size: 316.05 MiB -> 316.10 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants