Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal to support raw_attribute with raw pointer #124180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cre4ture
Copy link

@cre4ture cre4ture commented Apr 19, 2024

Hello rust community,

I'm still rather new to rust, but I collected experience with rust in the uutils project.
There I'm currently trying to make use of the conpty windows feature and stumbled across the same topic as discussion in #114854.

This was my solution to it and I found that its probably simpler as all other solutions I've seen on the discussion topic (#121951, #123604). And thus its easier to understand, use and therefor might take less discussions to get it approved.

The key element is, that I don't change the existing approach for normal data attributes with the Box::new(). I just extend the API with a second variant that takes raw pointers.

Just let me know what you think.
If there is positive feedback, I will adapt documentation and tests.

I also added a change (force_use_std_handles) that will be needed to have a proper support of the PSEUDOCONSOLE / conpty.
Its clear that this should be in a different PR. I will split it as needed after some feedback.

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ChrisDenton (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 19, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Sep 26, 2024

☔ The latest upstream changes (presumably #130865) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 27, 2024

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

@rust-log-analyzer

This comment has been minimized.

@Dylan-DPC
Copy link
Member

@cre4ture any updates on the CI failure? thanks

@cre4ture
Copy link
Author

@cre4ture any updates on the CI failure? thanks

@Dylan-DPC thanks for the trigger.
It was a small issue with the merge. It should be fixed now. Lets see what the CI says.
I was on vacation for 4 weeks and additionally I didn't expect much attention on this PR. That's the reason for the delay.

@rustbot rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants