Prefer identity equality over equating types during coercion.#124027
Merged
bors merged 1 commit intorust-lang:masterfrom Apr 17, 2024
Merged
Prefer identity equality over equating types during coercion.#124027bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
S-waiting-on-review
These types are always generic only over their own generic parameters with no inference variables involved.
oli-obk
force-pushed
the
define_opaque_types9
branch
from
24d9add to
9cc4e23
Compare
compiler-errors
approved these changes
Apr 16, 2024
Contributor
compiler-errors
left a comment
compiler-errors
left a comment
There was a problem hiding this comment.
Yeah. This may have interesting effects for fields equal up to normalization or anon consts that are equal after evaluation, but whatever, since these are internal impls anyways and relaxing/making this check more sophisticated will always just accept more code.
r=me when ci is green
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#123673 (Don't ICE for kind mismatches during error rendering) - rust-lang#123675 (Taint const qualifs if a static is referenced that didn't pass wfcheck) - rust-lang#123975 (Port the 2 `rust-lld` run-make tests to `rmake`) - rust-lang#124000 (Use `/* value */` as a placeholder) - rust-lang#124013 (Box::into_raw: make Miri understand that this is a box-to-raw cast) - rust-lang#124027 (Prefer identity equality over equating types during coercion.) - rust-lang#124036 (Remove `default_hidden_visibility: false` from wasm targets) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#124027 - oli-obk:define_opaque_types9, r=compiler-errors Prefer identity equality over equating types during coercion. These types are always generic only over their own generic parameters with no inference variables involved. r? `@compiler-errors` I love touching code that [hasn't changed meaningfully since 2016](rust-lang#41937)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These types are always generic only over their own generic parameters with no inference variables involved.
r? @compiler-errors
I love touching code that hasn't changed meaningfully since 2016