Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass RUST_BACKTRACE when running docker. #123330

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Pass RUST_BACKTRACE when running docker. #123330

merged 1 commit into from
Apr 2, 2024

Conversation

jfgoog
Copy link
Contributor

@jfgoog jfgoog commented Apr 1, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 1, 2024
@workingjubilee
Copy link
Member

This only passes in whatever's already set, right?

@Kobzol
Copy link
Contributor

Kobzol commented Apr 1, 2024

Could you please say a bit more about the motivation of this PR? Thanks!

@jfgoog
Copy link
Contributor Author

jfgoog commented Apr 1, 2024

Could you please say a bit more about the motivation of this PR? Thanks!

I've been using the script to debug CI issues in #122504. I found I needed a full backtrace for troubleshooting, and it seemed reasonable to me that this script would pass RUST_BACKTRACE through to docker.

onur-ozkan
onur-ozkan reviewed Apr 1, 2024
View reviewed changes
src/ci/docker/run.sh Outdated Show resolved Hide resolved
@Kobzol
Copy link
Contributor

Kobzol commented Apr 1, 2024

Ok, that makes sense.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 1, 2024

📌 Commit 652f6f7 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2024
@workingjubilee workingjubilee mentioned this pull request Apr 2, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@bors
Auto merge of rust-lang#123346 - workingjubilee:rollup-ix9qpsi, r=wor…
31075bb 
…kingjubilee

Rollup of 2 pull requests

Successful merges:

 - rust-lang#123323 (std::thread: set_name change for solaris/illumos.)
 - rust-lang#123330 (Pass RUST_BACKTRACE when running docker.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 347c579 into rust-lang:master Apr 2, 2024
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2024
@rust-timer
Unrolled build for rust-lang#123330
2e15c55 
Rollup merge of rust-lang#123330 - jfgoog:pass-backtrace, r=Kobzol

Pass RUST_BACKTRACE when running docker.
@rustbot rustbot added this to the 1.79.0 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onur-ozkan onur-ozkan onur-ozkan left review comments

Assignees

@Kobzol Kobzol

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jfgoog @rustbot @workingjubilee @Kobzol @bors @onur-ozkan