make "invalid fragment specifier" translatable #121067
Prev
Previous commit
add test to guard against inaccurate diagnostic
Also replaces an incomplete test
- Loading branch information
commit e3859d206ce49998f0f33e0c7fceca261aeaf7e8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| macro_rules! test { | ||
| ($wrong:id) => {}; | ||
| } //~^ ERROR: invalid fragment specifier `id` | ||
|
|
||
| // guard against breaking raw identifier diagnostic | ||
| macro_rules! test_raw_identifer { | ||
| ($wrong:r#if) => {}; | ||
| } //~^ ERROR: invalid fragment specifier `r#if` | ||
|
|
||
| fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| error: invalid fragment specifier `id` | ||
| --> $DIR/invalid-fragment-specifier.rs:2:6 | ||
| | | ||
| LL | ($wrong:id) => {}; | ||
| | ^^^^^^^^^ | ||
| | | ||
| = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `lifetime`, `literal`, `path`, `meta`, `tt`, `item` and `vis` | ||
|
|
||
| error: invalid fragment specifier `r#if` | ||
| --> $DIR/invalid-fragment-specifier.rs:7:6 | ||
| | | ||
| LL | ($wrong:r#if) => {}; | ||
| | ^^^^^^^^^^^ | ||
| | | ||
| = help: valid fragment specifiers are `ident`, `block`, `stmt`, `expr`, `pat`, `ty`, `lifetime`, `literal`, `path`, `meta`, `tt`, `item` and `vis` | ||
|
|
||
| error: aborting due to 2 previous errors | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have tests for invalid fragment specifiers, e.g.,
tests/ui/macros/macro-invalid-fragment-spec.rs. Actually instead of modifying this old test file, could you just remove it in favor of the new one you just added. I like your test file way better. After that, we're good to go!