Remove good path delayed bugs #120959
Merged
Remove good path delayed bugs #120959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @TaKO8Ki Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
|
cc @oli-obk |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #120980) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
The check within changed from `delay_span_bug` to `delay_good_path_bug` in rust-lang#110476, and removing the check altogether was considered. It's a very weak sanity check and gets in the way of removing good path delayed bugs altogether, so this PR just removes it.
nnethercote
force-pushed
the
rm-good_path
branch
from
f662cd8 to
54ffa9b
Compare
|
I fixed the conflicts. @bors r=oli-obk |
bors
added
S-waiting-on-bors
It's only has a single remaining purpose: to ensure that a diagnostic is printed when `trimmed_def_paths` is used. It's an annoying mechanism: weak, with odd semantics, badly named, and gets in the way of other changes. This commit replaces it with a simpler `must_produce_diag` mechanism, getting rid of a diagnostic `Level` along the way.
nnethercote
force-pushed
the
rm-good_path
branch
from
54ffa9b to
9f2aa09
Compare
|
And I fixed a tiny omission in a comment. @bors r=oli-obk |
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Feb 13, 2024
Remove good path delayed bugs Because they're not that useful, and kind of annoying. Details in the individual commits. r? `@compiler-errors`
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Feb 13, 2024
Remove good path delayed bugs Because they're not that useful, and kind of annoying. Details in the individual commits. r? ``@compiler-errors``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#120486 (Use generic `NonZero` internally.) - rust-lang#120500 (Implement intrinsics with fallback bodies) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120563 (Make `NonZero::get` generic.) - rust-lang#120847 (Continue compilation after check_mod_type_wf errors) - rust-lang#120959 (Remove good path delayed bugs) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114877 (unstable-book: add quick-edit link) - rust-lang#120548 (rustdoc: Fix handling of doc_auto_cfg feature for cfg attributes on glob reexport) - rust-lang#120549 (modify alias-relate to also normalize ambiguous opaques) - rust-lang#120959 (Remove good path delayed bugs) - rust-lang#120978 (match lowering: simplify block creation) - rust-lang#121019 (coverage: Simplify some parts of the coverage span refiner) - rust-lang#121021 (Extend intra-doc link chapter in the rustdoc book) - rust-lang#121031 (RustWrapper: adapt for coverage mapping API changes) Failed merges: - rust-lang#121014 (Remove `force_print_diagnostic`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 13, 2024
Rollup merge of rust-lang#120959 - nnethercote:rm-good_path, r=oli-obk Remove good path delayed bugs Because they're not that useful, and kind of annoying. Details in the individual commits. r? ```@compiler-errors```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because they're not that useful, and kind of annoying. Details in the individual commits.
r? @compiler-errors