Assert the value returned by NonZero*::get being non-zero
#119490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
EFanZh
changed the title
NonZero*::get being non-zeroNonZero*::get being non-zero
Member
|
this is already being done in #119452 |
Member
|
Going to go ahead and close in favor of that PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the values returned by
NonZero*::getfunctions are not considered non-zero by the compiler, which could lead to bad code generation: https://godbolt.org/z/1Wcb9Po9f. This PR asserts the returned values being non-zero, which could improve code generation in certain situations, one of which being divide an integer by the sum of two smaller non-zero integers: https://godbolt.org/z/sa64xzeec.