rustdoc-search: fix a race condition in search index loading

[notriddle]

var declare it in the global scope, and const does not. It needs to be declared in global scope.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/var

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const

const declarations do not create properties on globalThis when declared at the top level of a script.

Fixes a regression introduced by #118910

[GuillaumeGomez]

Can you send a regression test in a follow-up PR please?

@bors r+ p=1

[bors]

📌 Commit 09c8fd3 has been approved by GuillaumeGomez

It is now in the queue for this repository.

[bors]

⌛ Testing commit 09c8fd3 with merge 96df494...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 96df494 to master...

[notriddle]

Is there any way to force search.js to finish loading after search-index.js does in browser-ui-test? I couldn’t find one (the existing test cases already break on my machine).

[GuillaumeGomez]

You can't, however there is an easy way to prevent the bug: having a counter and when it reaches two, then calling the search. I can send a fix if you want?

[notriddle]

That sounds good, sure.

[GuillaumeGomez]

Still need a regression test though. ;)

[rust-timer]

Finished benchmarking commit (96df494): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.6%, 0.6%]	1
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	0.1%	[-0.5%, 0.6%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.4%	[-0.4%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-0.4%, -0.4%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.135s -> 671.047s (-0.16%)
Artifact size: 312.47 MiB -> 312.39 MiB (-0.03%)