Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegation implementation: step 1 #118947

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Delegation implementation: step 1 #118947

merged 1 commit into from
Jan 13, 2024

Conversation

Bryanskiy
Copy link
Contributor

@Bryanskiy Bryanskiy commented Dec 14, 2023 •
edited
Loading

See #118212 for more details.

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 14, 2023
@Bryanskiy
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 15, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryanskiy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 15, 2023
petrochenkov
petrochenkov reviewed Dec 18, 2023
View reviewed changes
compiler/rustc_ast/src/ast.rs Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Show resolved Hide resolved
compiler/rustc_ast_lowering/src/delegation.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_lowering/src/delegation.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2023
@bors

This comment was marked as resolved.

Sign in to view
@Bryanskiy Bryanskiy force-pushed the delegStep1 branch 3 times, most recently from ac52ac9 to a577b1c Compare December 25, 2023 16:45
petrochenkov
petrochenkov reviewed Dec 25, 2023
View reviewed changes
tests/ui/delegation/bad-resolve.rs Outdated Show resolved Hide resolved
tests/ui/delegation/parse.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_pretty/src/pprust/state/item.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_pretty/src/pprust/state/item.rs Outdated Show resolved Hide resolved
compiler/rustc_ast/src/ast.rs Show resolved Hide resolved
compiler/rustc_ast_lowering/src/delegation.rs Outdated Show resolved Hide resolved
compiler/rustc_ast_lowering/src/delegation.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/astconv/mod.rs Show resolved Hide resolved
compiler/rustc_ast_lowering/src/delegation.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov self-assigned this Jan 12, 2024
@petrochenkov
Copy link
Contributor

tidy needs fixing.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2024
@petrochenkov
Copy link
Contributor

@bors r=petrochenkov,lcnr

@bors
Copy link
Contributor

bors commented Jan 12, 2024

📌 Commit d69cd64 has been approved by petrochenkov,lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
@bors
Auto merge of rust-lang#118947 - Bryanskiy:delegStep1, r=petrochenkov…
7329f26 
…,lcnr

Delegation implementation: step 1

See rust-lang#118212 for more details.

r? `@petrochenkov`
@bors
Copy link
Contributor

bors commented Jan 12, 2024

⌛ Testing commit d69cd64 with merge 7329f26...

@bors
Copy link
Contributor

bors commented Jan 12, 2024

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2024
@petrochenkov
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jan 13, 2024

⌛ Testing commit d69cd64 with merge 89110da...

@bors
Copy link
Contributor

bors commented Jan 13, 2024

☀️ Test successful - checks-actions
Approved by: petrochenkov,lcnr
Pushing 89110da to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 13, 2024
@bors bors merged commit 89110da into rust-lang:master Jan 13, 2024
12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 13, 2024
This was referenced Jan 13, 2024
Closed
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (89110da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.6% [-3.4%, -0.8%] 7
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 666.315s -> 668.566s (0.34%)
Artifact size: 308.15 MiB -> 308.16 MiB (0.00%)

@fmease fmease added the F-fn_delegation `#![feature(fn_delegation)]` label Jan 13, 2024
@fmease fmease mentioned this pull request Jan 13, 2024
Open
25 tasks
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 25, 2024
@bors
Auto merge of rust-lang#118947 - Bryanskiy:delegStep1, r=petrochenkov…
5a45dbe 
…,lcnr

Delegation implementation: step 1

See rust-lang#118212 for more details.

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

@ytmimi ytmimi ytmimi left review comments

@lcnr lcnr lcnr left review comments

@petrochenkov petrochenkov petrochenkov approved these changes

Assignees

@petrochenkov petrochenkov

@lcnr lcnr

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc F-fn_delegation `#![feature(fn_delegation)]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
10 participants
@Bryanskiy @rust-log-analyzer @bors @petrochenkov @rustbot @lcnr @rust-timer @cjgillot @ytmimi @fmease