Skip to content

Add support for i586-unknown-netbsd as target. #117170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 29, 2023
Merged

Add support for i586-unknown-netbsd as target. #117170

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6642b4b
Add support for i586-unknown-netbsd as target.
he32 Oct 25, 2023
391b472
rustc_llvm/build.rs: improve comment for NetBSD/i386 targets
he32 Oct 26, 2023
893e726
i586_unknown_netbsd.rs: fix formatting.
he32 Oct 27, 2023
0f04e2d
For i586/NetBSD: fix another formatting insistence.
he32 Oct 27, 2023
a510288
i586_unknown_netbsd.rs: drop "-m32" flag insertion to gcc.
he32 Oct 28, 2023
d9ddad3
i586-unknown-netbsd: add entry in platform-support.md.
he32 Oct 28, 2023
f5fa36f
i586-unknown-netbsd platform-support.md: fix typo.
he32 Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
i586-unknown-netbsd platform-support.md: fix typo.
  • Loading branch information
@he32
he32 committed Oct 28, 2023
commit f5fa36fbb72fe6d676adcb9bb7c1cba869c81c00
2 changes: 1 addition & 1 deletion src/doc/rustc/src/platform-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ target | std | notes
`i586-pc-windows-msvc` | * | 32-bit Windows w/o SSE [^x86_32-floats-x87]
`i586-unknown-linux-gnu` | ✓ | 32-bit Linux w/o SSE (kernel 3.2, glibc 2.17) [^x86_32-floats-x87]
`i586-unknown-linux-musl` | ✓ | 32-bit Linux w/o SSE, MUSL [^x86_32-floats-x87]
[`i586-unknown-netbsd`](platform-support/netbsd.md) | ✓ | 32-bir x86, restricted to Pentium
[`i586-unknown-netbsd`](platform-support/netbsd.md) | ✓ | 32-bit x86, restricted to Pentium
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a footnote for the usual x86-32 float problem? See the other i686/i586 targets. Depending on whether this target has SSE or not, you need x86_32-floats-return-ABI or x86_32-floats-x87.

[`i686-linux-android`](platform-support/android.md) | ✓ | 32-bit x86 Android [^x86_32-floats-return-ABI]
`i686-unknown-freebsd` | ✓ | 32-bit FreeBSD [^x86_32-floats-return-ABI]
`i686-unknown-linux-musl` | ✓ | 32-bit Linux with MUSL [^x86_32-floats-return-ABI]
Expand Down