Skip to content

Location-insensitive polonius: consider a loan escaping if an SCC has member constraints applied only #116960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Location-insensitive polonius: consider a loan escaping if an SCC has member constraints applied only #116960

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b76518
add non-regression test for issue 116657
lqd Oct 19, 2023
c69bd94
make `applied_member_constraints` accept an SCC instead of a region
lqd Oct 19, 2023
fa45efa
consider a loan escapes the function via applied member constraints
lqd Oct 19, 2023
d9c213c
slight Default cleanup for option
lqd Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
slight Default cleanup for option
  • Loading branch information
@lqd
lqd committed Oct 20, 2023
commit d9c213cd5e5b5ec480297960ca080ed5b493f4f1
9 changes: 2 additions & 7 deletions compiler/rustc_session/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3420,9 +3420,10 @@ impl DumpMonoStatsFormat {

/// `-Zpolonius` values, enabling the borrow checker polonius analysis, and which version: legacy,
/// or future prototype.
#[derive(Clone, Copy, PartialEq, Hash, Debug)]
#[derive(Clone, Copy, PartialEq, Hash, Debug, Default)]
pub enum Polonius {
/// The default value: disabled.
#[default]
Off,

/// Legacy version, using datalog and the `polonius-engine` crate. Historical value for `-Zpolonius`.
Expand All @@ -3432,12 +3433,6 @@ pub enum Polonius {
Next,
}

impl Default for Polonius {
fn default() -> Self {
Polonius::Off
}
}

impl Polonius {
/// Returns whether the legacy version of polonius is enabled
pub fn is_legacy_enabled(&self) -> bool {
Expand Down