Subtree update of rust-analyzer

[lnicola]

r? @ghost

[rustbot]

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

• 5855bd8
• 22b18b9
• 65532e4
• 695c612
• 0840038
• ad73597
• 862693f
• e5e937a
• 8139e8e
• 50678e0
• f93b6ac
• 6572ec8
• c387361
• 547bcf8
• aaa1e8e
• b3f4574
• 983094a
• 03f676e
• 862a300
• 7e9b25b
• 11ffcc0
• 8a23314
• ef58843
• dbe5392
• d7faec8
• a8581aa
• 4a8622c
• 0427a23
• 36be913
• c22bb03
• d6afb4f
• b57658d
• d6fef2c
• d3cc3bc
• e478db7
• 2b580a1
• 520aad1
• a158670
• 3b1b58c
• 7eec17e
• c945f90
• df75809
• 4791a5d
• fd39a30
• b1f89a8
• dca63d1
• 84e1d27
• f19479a
• 4c9d2c7
• 609bdbc
• 59bcbaf
• 2910dbf
• b0fe99f
• d646ae8
• cdaadb6
• 972a19f
• 1752178
• fccae08
• ab62c01
• 2ededa2
• 03c5603
• 54866a0
• 4778255
• 7b8330f
• 7e9da40
• 87e2c31
• 16ac6c2

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

GITHUB_ACTION=__run_7
GITHUB_ACTIONS=true
GITHUB_ACTION_REF=
GITHUB_ACTION_REPOSITORY=
GITHUB_ACTOR=lnicola
GITHUB_API_URL=https://api.github.com
GITHUB_BASE_REF=master
GITHUB_ENV=/home/runner/work/_temp/_runner_file_commands/set_env_154c82f3-d0ad-4c43-82e7-4a7275c01e56
GITHUB_EVENT_NAME=pull_request
---
GITHUB_SERVER_URL=https://github.com
GITHUB_SHA=ccdc5e1d606c4afa68c5017ac3e7b9c3e106c44b
GITHUB_STATE=/home/runner/work/_temp/_runner_file_commands/save_state_154c82f3-d0ad-4c43-82e7-4a7275c01e56
GITHUB_STEP_SUMMARY=/home/runner/work/_temp/_runner_file_commands/step_summary_154c82f3-d0ad-4c43-82e7-4a7275c01e56
GITHUB_TRIGGERING_ACTOR=lnicola
GITHUB_WORKFLOW_REF=rust-lang/rust/.github/workflows/ci.yml@refs/pull/116847/merge
GITHUB_WORKFLOW_SHA=ccdc5e1d606c4afa68c5017ac3e7b9c3e106c44b
GITHUB_WORKSPACE=/home/runner/work/rust/rust
GOROOT_1_19_X64=/opt/hostedtoolcache/go/1.19.13/x64
---

error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
  --> crates/rustc-dependencies/src/lib.rs:14:13
   |
14 |     pub use ::rustc_lexer::*;
   |
   = note: see issue #27812 <https://github.com/rust-lang/rust/issues/27812> for more information
   = help: add `#![feature(rustc_private)]` to the crate attributes to enable


error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
  --> crates/rustc-dependencies/src/lib.rs:25:13
   |
25 |     pub use ::rustc_parse_format::*;
   |
   = note: see issue #27812 <https://github.com/rust-lang/rust/issues/27812> for more information
   = help: add `#![feature(rustc_private)]` to the crate attributes to enable


error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
  --> crates/rustc-dependencies/src/lib.rs:36:13
   |
36 |     pub use ::rustc_abi::*;
   |
   = note: see issue #27812 <https://github.com/rust-lang/rust/issues/27812> for more information
   = help: add `#![feature(rustc_private)]` to the crate attributes to enable


error[E0658]: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead?
  --> crates/rustc-dependencies/src/lib.rs:47:13
   |
47 |     pub use ::rustc_index::*;
   |
   = note: see issue #27812 <https://github.com/rust-lang/rust/issues/27812> for more information
   = help: add `#![feature(rustc_private)]` to the crate attributes to enable

[lnicola]

CC @HKalbasi

Locally I get:

   --> crates/hir-def/src/data/adt.rs:181:10
    |
181 |     Some(ReprOptions { int, align: max_align, pack: min_pack, flags })
    |          ^^^^^^^^^^^ missing `field_shuffle_seed`

But I'm not sure I'm building it the right way.

[HKalbasi]

It seems the problem is that default-features are always included when the crate is added by the rustc_private. Is there any way to disable them? To unblocking the sync, we can ignore the CI breakage checking and unconditionally depend on the crates.io version for now.

By the way, what was the previous sync problem and how it got fixed?

[Veykril]

CC @HKalbasi

Locally I get:

   --> crates/hir-def/src/data/adt.rs:181:10
    |
181 |     Some(ReprOptions { int, align: max_align, pack: min_pack, flags })
    |          ^^^^^^^^^^^ missing `field_shuffle_seed`

But I'm not sure I'm building it the right way.

That's because with the nightly feature, that field exists (as its type comes from rustc_datastructures), with it disabled it doesn't which is what we currently work with.

[lnicola]

By the way, what was the previous sync problem and how it got fixed?

error[E0463]: can't find crate for hkalbasi_rustc_ap_rustc_abi

There was rust-lang/rust-analyzer#15691, but I don't know if it's fixed or it just fails earlier now.

[hlopko]

@Veykril and @HKalbasi, could you please advice how we can move this PR forward? This sync is much needed, and the gap between RA and rust repos is growing larger and larger.

[HKalbasi]

I opened this zulip stream for discussion on the problem: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Depend.20on.20rustc_private.20crates.20without.20default.20features

If it ends up being unsolvable in a short time, we can disable this and unconditionally depend on the crates.io version to unblock the sync.

[lnicola]

Closing in favour of #117544.

[HKalbasi]

I made #117544 to just test if using path dependencies works, and it didn't due some problem with Cargo.lock which I don't understand really. I will close that PR.

I will try to go with making the nightly feature additive that was suggested in the zulip thread in the following days.

[lnicola]

Doesn't 23f9077 need a corresponding lockfile change?

[HKalbasi]

I updated the lockfile in a2bd911 but it didn't work.

[HKalbasi]

@lnicola Can you please create a new sync PR containing this (rust-lang/rust-analyzer#15849) commit?