Skip to content

Bring back generic parameters for indices in rustc_abi and make it compile on stable #116269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Bring back generic parameters for indices in rustc_abi and make it compile on stable #116269

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b99d73
Unglob rustc_abi imports
Veykril Sep 29, 2023
b47ad3b
Bring back generic FieldIdx
Veykril Sep 29, 2023
f14b7c9
Move FieldIdx and Layout to rustc_target
Veykril Sep 29, 2023
e8a2673
Add VariantIdx back
Veykril Sep 29, 2023
67e5eb6
Cfg out ReprOption::field_shuffle_seed
Veykril Sep 29, 2023
6d141c1
Implement Deref<LayoutS> for Layout
Veykril Sep 29, 2023
b25c845
Add some docs regarding rustc_abi rust-analyzer compat changes
Veykril Sep 29, 2023
2d73d30
Fix incorrect inlining of RangeInclusive::size_hint
Veykril Sep 29, 2023
0aedec4
Remove unnecessary features from rustc_abi
Veykril Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix incorrect inlining of RangeInclusive::size_hint
  • Loading branch information
@Veykril
Veykril committed Oct 2, 2023
commit 2d73d30a3c4d5d06dbdc35c3cf2aabf9e3387a3d
2 changes: 1 addition & 1 deletion compiler/rustc_abi/src/layout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ pub trait LayoutCalculator {
..=all_indices.rev().find(|v| needs_disc(*v)).unwrap();

let count =
niche_variants.end().index() as u128 - niche_variants.start().index() as u128;
(niche_variants.end().index() as u128 - niche_variants.start().index() as u128) + 1;

// Find the field with the largest niche
let (field_index, niche, (niche_start, niche_scalar)) = variants[largest_variant_index]
Expand Down