Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate rustc_hir_analysis to session diagnostic [Part 6] #115853

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Sep 14, 2023

Part 6: Finish coherence/inherent_impls.rs file

Part 6: Finish `coherence/inherent_impls.rs`
@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 14, 2023
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 15, 2023

📌 Commit 8723af5 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2023
@bors
Copy link
Contributor

bors commented Sep 15, 2023

⌛ Testing commit 8723af5 with merge e7f9f48...

@bors
Copy link
Contributor

bors commented Sep 15, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing e7f9f48 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 15, 2023
@bors bors merged commit e7f9f48 into rust-lang:master Sep 15, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 15, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e7f9f48): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.8%, 0.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.442s -> 633.484s (0.32%)
Artifact size: 318.11 MiB -> 318.18 MiB (0.02%)

@obeis obeis deleted the hir-analysis-migrate-diagnostics-6 branch September 15, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants