Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused Lift impls #115831

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Remove unused Lift impls #115831

merged 5 commits into from
Sep 18, 2023

Commits on Sep 17, 2023

  1. Remove RegionHighlightMode::tcx. 

    It's easier to pass it in to the one method that needs it
(`highlighting_region_vid`) than to store it in the type. This means
`RegionHighlightMode` can impl `Default`.
    @nnethercote
    nnethercote committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    1281d43 View commit details
    Browse the repository at this point in the history

  2. Remove unused Display impls.

    @nnethercote
    nnethercote committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    46fe65d View commit details
    Browse the repository at this point in the history

  3. Rename CloneLiftImpls as TrivialLiftImpls. 

    To match `TrivialTypeTraversalImpls` and
`TrivialTypeTraversalAndLiftImpls`, and because the `Clone` doesn't mean
anything.
    @nnethercote
    nnethercote committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    6b1980f View commit details
    Browse the repository at this point in the history

  4. Remove unused Lift derives. 

    I found these by commenting out all `Lift` derives and then adding back
the ones that were necessary to successfully compile.
    @nnethercote
    nnethercote committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    af7d3e5 View commit details
    Browse the repository at this point in the history

  5. Remove more unused Lift impls.

    @nnethercote
    nnethercote committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    abe2a68 View commit details
    Browse the repository at this point in the history