Fix error report for size overflow from transmute #115529
Conversation
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
| @@ -2920,6 +2920,12 @@ impl<'tcx> InferCtxtPrivExt<'tcx> for TypeErrCtxt<'_, 'tcx> { | |||
| rustc_transmute::Reason::DstIsTooBig => { | |||
| format!("The size of `{src}` is smaller than the size of `{dst}`") | |||
| } | |||
| rustc_transmute::Reason::SrcSizeOverflow => { | |||
| format!("the size of `{src}` is overflow") | |||
There was a problem hiding this comment.
Can you make this more like LayoutError::SizeOverflow?
| format!("the size of `{src}` is overflow") | |
| format!("values of the type `{src}` are too big for the current architecture") |
Same for dst.
chenyukang
force-pushed
the
yukang-fix-115402-overflowsize
branch
from
559a4a0 to
00010ed
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (aeddd2d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 628.843s -> 628.436s (-0.06%) |
Fixes #115402
The span in the error reporting always points to the
dst, this is an old issue, I may open another PR to fix it.