-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't manually compute param indices when adding implicit Sized
and ConstParamHasTy
#115361
Conversation
…and ConstParamHasTy
712bcc4
to
c5d0f6c
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (53a0397): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 630.051s -> 628.237s (-0.29%) |
We can just use resolve_bound_vars to compute these indices faithfully.
This also makes the code easier to support where clauses on
non_lifetime_binders
(likewhere for<T: Debug> ...
, etc, which I've got a WIP implementation of).r? @cjgillot