Skip rendering metadata strings from include_str!/include_bytes!

[saethlin]

The const rendering code in rustdoc completely ignores consts from expansions, but the compiler was rendering all consts. So some consts (namely those from include_bytes!) were rendered then ignored.

Most of the diff here is from moving print_const_expr from rustdoc into rustc_hir_pretty so that it can be used in rustdoc and when building rmeta files.

[saethlin]

r? compiler

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

[petrochenkov]

The current version addresses my previous comments, it's just unfortunate that it introduces a new dependency between rustc crates, especially on rustc_middle.

Let's perhaps move print_const_expr directly to compiler\rustc_metadata\src\rmeta\encoder.rs, reexport it through rustc_metadata root, and rename it to rendered_const for consistency with the query.
@rustbot author

[saethlin]

Yeah, that seems better. I wish we had a diagram of the rustc crates dependency graph...
@rustbot ready

[petrochenkov]

@bors r+

[bors]

📌 Commit 159ad5f has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

⌛ Testing commit 159ad5f with merge 1fb6947...

[bors]

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 1fb6947 to master...

[rust-timer]

Finished benchmarking commit (1fb6947): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.3%, 0.3%]	1
Regressions ❌ (secondary)	0.4%	[0.3%, 0.7%]	6
Improvements ✅ (primary)	-2.9%	[-10.3%, -0.3%]	28
Improvements ✅ (secondary)	-2.6%	[-3.7%, -1.7%]	9
All ❌✅ (primary)	-2.8%	[-10.3%, 0.3%]	29

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-4.2%, -1.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-4.2%, 0.5%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-5.5%	[-10.8%, -2.0%]	13
Improvements ✅ (secondary)	-2.7%	[-3.0%, -2.5%]	3
All ❌✅ (primary)	-5.5%	[-10.8%, -2.0%]	13

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-10.4%, -0.0%]	58
Improvements ✅ (secondary)	-7.7%	[-8.2%, -7.3%]	12
All ❌✅ (primary)	-2.1%	[-10.4%, -0.0%]	58

Bootstrap: 631.705s -> 627.894s (-0.60%)
Artifact size: 316.63 MiB -> 316.38 MiB (-0.08%)

[saethlin]

Regressions look like recovery from a spurious improvement in the previous run, and are way less significant than the improvements.
@rustbot label: +perf-regression-triaged

[Kobzol]

Very nice results, awesome work!