tests: unset RUSTC_LOG_COLOR in a test
#113158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `RUSTC_LOG_COLOR=always` is sometimes useful if tools that one pipes `RUSTC_LOG` into support coloured output, but it makes this test fail. Signed-off-by: David Wood <david@davidtw.co>
|
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
wesleywiser
approved these changes
Jul 7, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jul 8, 2023
…-test, r=wesleywiser tests: unset `RUSTC_LOG_COLOR` in a test Setting `RUSTC_LOG_COLOR=always` is sometimes useful if tools that one pipes `RUSTC_LOG` into support coloured output, but it makes this test fail because it has a `.stderr` file with `WARN` log output.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 8, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#112931 (Enable zlib in LLVM on aarch64-apple-darwin) - rust-lang#113158 (tests: unset `RUSTC_LOG_COLOR` in a test) - rust-lang#113173 (CI: include workflow name in concurrency group) - rust-lang#113335 (Reveal opaques in new solver) - rust-lang#113390 (CGU formation tweaks) - rust-lang#113399 (Structurally normalize again for byte string lit pat checking) - rust-lang#113412 (Add basic types to SMIR) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
RUSTC_LOG_COLOR=alwaysis sometimes useful if tools that one pipesRUSTC_LOGinto support coloured output, but it makes this test fail because it has a.stderrfile withWARNlog output.