Don't emit same goal as input during wf::unnormalized_obligations
#112965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
changed the title
wf::unnormalized_obligations
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
circular-wf
branch
from
75ac445
to
2eb7d69
Compare
|
Well, looks like we were dropping some WF obligations on the ground. Seems like that's not sufficient to actually cause unsoundness with the UI tests committed already, but does seem like this change has the right effect 😸 |
|
@bors r+ rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 24, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#111087 (Implement `Sync` for `mpsc::Sender`) - rust-lang#112763 (Bump compiler_builtins) - rust-lang#112963 (Stop bubbling out hidden types from the eval obligation queries) - rust-lang#112965 (Don't emit same goal as input during `wf::unnormalized_obligations`) - rust-lang#112973 (Make sure to include default en-US ftl resources for `rustc_error` crate) - rust-lang#112981 (Fix return type notation errors with -Zlower-impl-trait-in-trait-to-assoc-ty) - rust-lang#112983 (Fix return type notation associated type suggestion when -Zlower-impl-trait-in-trait-to-assoc-ty) - rust-lang#112986 (Update cargo) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @aliemjay cc @lcnr
I accidentally pruned the logic to handle
WF(?0)when writingwf::unnormalized_obligations.idk if you wanted to construct a test first, but this is an obvious fix. Copied the comment from above.
Fixes rust-lang/trait-system-refactor-initiative#36