Skip to content

Conversation

@Zalathar
Copy link
Contributor

Without an explicit <meta charset> declaration, some browsers (e.g. Safari) won't detect the page encoding as UTF-8, causing unicode characters in the dump output to display incorrectly.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2023
@Zalathar
Copy link
Contributor Author

Zalathar commented Jun 17, 2023

Before (with incorrectly-decoded characters):
Screenshot 2023-06-17 at 2 54 16 pm

After (with correct decoding of unicode brackets):
Screenshot 2023-06-17 at 2 52 56 pm

@Noratrieb
Copy link
Member

thanks!
r? Nilstrieb
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 17, 2023

📌 Commit 3eddb29 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112352 (Fix documentation build on FreeBSD)
 - rust-lang#112644 (Correct types in method descriptions of `NonZero*` types)
 - rust-lang#112683 (fix ICE on specific malformed asm clobber_abi)
 - rust-lang#112707 ([rustdoc] Fix invalid handling of "going back in history" when "go to only search result" setting is enabled)
 - rust-lang#112719 (Replace fvdl with ffx, allow test without install)
 - rust-lang#112728 (Add `<meta charset="utf-8">` to `-Zdump-mir-spanview` output)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 981a2a2 into rust-lang:master Jun 17, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 17, 2023
@Zalathar Zalathar deleted the spanview-charset branch June 18, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants