Skip to content

Add OsStr inherent fns to test for and strip str prefixes. #111317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add OsStr inherent fns to test for and strip str prefixes. #111317

wants to merge 2 commits into from

Conversation

jmillikin
Copy link
Contributor

@jmillikin jmillikin commented May 7, 2023 •
edited
Loading

A reduced subset of PR #111059:

  • OsStr::starts_with() tests whether an OsStr has a prefix matching the given Pattern.

  • OsStr::strip_prefix() returns the OsStr after removing a prefix matching the given Pattern.

ACP: rust-lang/libs-team#114

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 7, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 7, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@jmillikin
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 7, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jmillikin jmillikin force-pushed the osstr-str-prefix-fns branch from 0fa3703 to fbd7174 Compare May 7, 2023 10:12
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jmillikin added 2 commits May 7, 2023 19:41
@jmillikin
Add OsStr inherent fns to test for and strip str prefixes.
525fc99 
* `OsStr::starts_with()` tests whether an `OsStr` has a prefix matching
  the given `Pattern`.

* `OsStr::strip_prefix()` returns the `OsStr` after removing a prefix
  matching the given `Pattern`.
@jmillikin
Add a fast path for OsStr prefix functions with str patterns.
024c947
@jmillikin jmillikin force-pushed the osstr-str-prefix-fns branch from fbd7174 to 024c947 Compare May 7, 2023 10:42
@bors
Copy link
Collaborator

bors commented Jun 14, 2023

☔ The latest upstream changes (presumably #112624) made this pull request unmergeable. Please resolve the merge conflicts.

@jmillikin jmillikin closed this Jul 4, 2023
@jmillikin jmillikin deleted the osstr-str-prefix-fns branch July 4, 2023 20:36
@CryZe
Copy link
Contributor

CryZe commented Jul 4, 2023

Why was this closed?

@jmillikin
Copy link
Contributor Author

Just garbage-collecting ancient stale PRs. It was open for months with no review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmillikin @rustbot @rust-log-analyzer @bors @CryZe @joshtriplett