Skip to content

Update Clippy #111255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 138 commits into from
May 6, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
138 commits
Select commit Hold shift + click to select a range
8889587
Merge from rustc
RalfJung Mar 22, 2023
95bb486
Merge from rustc
oli-obk Mar 23, 2023
b6495af
Merge from rustc
RalfJung Mar 24, 2023
a937f49
Merge from rustc
oli-obk Apr 4, 2023
f5ac844
Refactor unwind from Option to a new enum
nbdd0121 Oct 8, 2022
293c1a1
Fix tools
nbdd0121 Oct 10, 2022
0963a66
Make elaborator generic
compiler-errors Apr 6, 2023
d048c11
Auto merge of #110031 - compiler-errors:generic-elaboration, r=b-naber
bors Apr 9, 2023
fe129a0
Merge from rustc
saethlin Apr 10, 2023
6b95029
Merge commit '83e42a2337dadac915c956d125f1d69132f36425' into clippyup
flip1995 Apr 11, 2023
5989400
resolve: Pre-compute non-reexport module children
petrochenkov Apr 10, 2023
7a0fb90
Tweak output for 'add line' suggestion
estebank Mar 18, 2023
4680aa2
Special-case item attributes in the suggestion output
estebank Apr 10, 2023
d61570c
Auto merge of #110160 - petrochenkov:notagain2, r=cjgillot
bors Apr 14, 2023
8f53926
Alloc `hir::Lit` in an arena to remove the destructor from `Expr`
Noratrieb Mar 25, 2023
0a81f82
add `semicolon_outside_block_if_singleline` lint
Centri3 Apr 17, 2023
dfccebe
make cargo test pass
Centri3 Apr 17, 2023
a7c3301
refactor
Centri3 Apr 17, 2023
a57445d
make cargo test pass, again
Centri3 Apr 17, 2023
80707aa
improve description a bit
Centri3 Apr 17, 2023
f85928f
Merge from rustc
oli-obk Apr 17, 2023
89f0aaa
Force -Zflatten-format-args=no in Clippy.
m-ou-se Apr 17, 2023
fa1efa8
refactor
Centri3 Apr 18, 2023
2ebfbc5
Remove very useless `as_substs` usage from clippy
WaffleLapkin Apr 18, 2023
1dfc231
clippy: add test for https://github.com/rust-lang/rust-clippy/issues/…
matthiaskrgr Apr 18, 2023
d3b1001
Auto merge of #110496 - WaffleLapkin:🏳️‍⚧️sound, r=compiler-errors
bors Apr 19, 2023
2745c87
Dont suggest suboptimal_flops unavailable in nostd
lukaslueg Apr 19, 2023
a3aeec4
config instead of new lint and don't panic
Centri3 Apr 20, 2023
41f6d88
make cargo test pass
Centri3 Apr 20, 2023
8ead58c
Remove WithOptconstParam.
cjgillot May 8, 2022
afa28e6
change usages of explicit_item_bounds to bound_explicit_item_bounds
kylematsuda Apr 17, 2023
097309c
add EarlyBinder to output of explicit_item_bounds; replace bound_expl…
kylematsuda Apr 17, 2023
55d8146
add subst_identity_iter and subst_identity_iter_copied methods on Ear…
kylematsuda Apr 17, 2023
654d12f
use is_inside_const_context query for in_constant
y21 Apr 20, 2023
e8197b1
Auto merge of #109999 - m-ou-se:flatten-format-args, r=oli-obk
bors Apr 20, 2023
84bab31
Auto merge of #96840 - cjgillot:query-feed, r=oli-obk
bors Apr 21, 2023
68c4776
offset_of
beepster4096 Sep 11, 2022
85d7de2
fix false positive
Centri3 Apr 21, 2023
cb3e0fb
Evaluate place expression in `PlaceMention`.
cjgillot Nov 24, 2022
7f13e6d
Allow `LocalDefId` as the argument to `def_path_str`
oli-obk Feb 16, 2023
86d8f12
Auto merge of #106934 - DrMeepster:offset_of, r=WaffleLapkin
bors Apr 22, 2023
a43708a
Merge from rustc
RalfJung Apr 22, 2023
f30fc0a
Auto merge of #104844 - cjgillot:mention-eval-place, r=jackh726,RalfJung
bors Apr 22, 2023
628605e
Ignore `shadow` warns in code from macro expansions
lochetti Apr 22, 2023
583c97e
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 Apr 23, 2023
0add5bb
Bump Clippy version -> 0.1.71
flip1995 Apr 23, 2023
d5a2c2b
Bump nightly version -> 2023-04-23
flip1995 Apr 23, 2023
36bf3ef
Fix dogfood test
flip1995 Apr 23, 2023
acf50a7
Improve the help message + add a help span
blyxyas Apr 23, 2023
f16bfa4
Auto merge of #10703 - flip1995:rustup, r=flip1995
bors Apr 23, 2023
a1b75c5
Merge commit 'a3ed905928a03b6e433d0b429190bf3a847128b3' into clippyup
flip1995 Apr 23, 2023
69da902
Detect if expressions with boolean assignments to the same target
samueltardieu Feb 26, 2023
572eecd
split test into 2
matthiaskrgr Apr 23, 2023
316d83a
Auto merge of #10670 - lukaslueg:issue10634, r=Jarcho
bors Apr 23, 2023
496c110
Auto merge of #10679 - y21:better-const-ctx-check, r=Jarcho
bors Apr 23, 2023
4ed4869
Auto merge of #108118 - oli-obk:lazy_typeck, r=cjgillot
bors Apr 23, 2023
e1f6305
Auto merge of #10704 - matthiaskrgr:splitest, r=llogiq
bors Apr 23, 2023
022baa5
Remove check for `lib.register_*` and `src/docs*` in `cargo dev updat…
Alexendoo Apr 23, 2023
797a7fe
Auto merge of #10706 - Alexendoo:remove-old-generated-files-check, r=…
bors Apr 23, 2023
d2061fa
Spelling
jsoref Apr 13, 2023
6f7801f
Rewrite search_same description
jsoref Apr 17, 2023
7a870ae
Auto merge of #10432 - samueltardieu:issue-10430, r=Manishearth
bors Apr 23, 2023
e8726b2
also check for rest pat in `redundant_pattern_matching`
y21 Apr 23, 2023
96f8471
Auto merge of #10649 - jsoref:spelling, r=Jarcho
bors Apr 23, 2023
5161c4c
Auto merge of #10697 - lochetti:fix_9757, r=dswij
bors Apr 24, 2023
6c859b6
Clippy book: hotfix for broken link
flip1995 Apr 24, 2023
26f9fce
Merge from rustc
RalfJung Apr 24, 2023
3045998
Update allow_attributes_false_positive.rs
Centri3 Apr 24, 2023
4b6fdb4
Auto merge of #10683 - Centri3:allow-attributes, r=Alexendoo
bors Apr 24, 2023
30db6ed
Auto merge of #10707 - y21:redudant_pattern_matching_rest_pat, r=Mani…
bors Apr 24, 2023
c4f2c48
Auto merge of #10702 - blyxyas:fix-let_underscore_untyped_help_messag…
bors Apr 24, 2023
5514d9f
Auto merge of #110718 - flip1995:clippyup, r=Manishearth
bors Apr 24, 2023
4a76b6f
Add the warning to all documentation.
blyxyas Apr 24, 2023
acfb2c4
don't check if from macro invocation
Centri3 Apr 18, 2023
8efe9ff
run cargo dev fmt
Centri3 Apr 18, 2023
1ac30d3
make cargo test pass
Centri3 Apr 18, 2023
14a6fa4
use in_external_macro
Centri3 Apr 20, 2023
abd2c1e
Auto merge of #10665 - Centri3:string_lit_as_bytes_changes, r=giraffate
bors Apr 25, 2023
637d10b
Catching, stray, commas, (I'll, never, learn, to, use, them, correctl…
xFrednet Apr 25, 2023
aa6c27a
change names to not be implicitly negative
Centri3 Apr 25, 2023
e3ee10d
use `//@` for commands in tests
Centri3 Apr 25, 2023
9cf9642
Use `ty::TraitRef::new` in clippy
WaffleLapkin Apr 25, 2023
19465c9
Auto merge of #10715 - xFrednet:changelog-1-69, r=llogiq
bors Apr 25, 2023
a7335cb
Auto merge of #10712 - blyxyas:fix-fixflag_implies_all_targets, r=llogiq
bors Apr 25, 2023
331c547
Rollup merge of #110556 - kylematsuda:earlybinder-explicit-item-bound…
matthiaskrgr Apr 25, 2023
8c8cf40
Update lint_configuration.md
Centri3 Apr 25, 2023
990bbdc
Auto merge of #10656 - Centri3:master, r=xFrednet
bors Apr 25, 2023
92645b0
Merge from rustc
RalfJung Apr 26, 2023
9564895
Fix uses of `TraitRef::identity` in clippy and rustdoc
WaffleLapkin Apr 26, 2023
9428138
adds lint to detect construction of unit struct using `default`
Icxolu Apr 25, 2023
0339d4e
rename `needs_infer` to `has_infer`
BoxyUwU Apr 27, 2023
273c898
Fix #10713 and move the tests to a subdir
blyxyas Apr 27, 2023
83504fa
Make clippy happy
compiler-errors Apr 25, 2023
19b3b22
Merge from rustc
RalfJung Apr 28, 2023
d1f55e6
run linkcheck in Remark CI
SergenKaraoglan Apr 27, 2023
b7939f4
Auto merge of #10720 - SergenKaraoglan:personal, r=flip1995
bors Apr 28, 2023
81a6141
uplift `clippy::clone_double_ref` as `suspicious_double_ref_op`
fee1-dead Apr 28, 2023
f37054b
Remove useless span magic
blyxyas Apr 28, 2023
2b5820d
Change module import system
blyxyas Apr 28, 2023
395b1f5
Rename items + Delete `imported_module.stderr`
blyxyas Apr 28, 2023
3594d55
Auto merge of #10719 - blyxyas:fix-items_after_test_mod_imported_modu…
bors Apr 28, 2023
2ed254e
Clarify docs for RESULT_LARGE_ERR
lukaslueg Apr 29, 2023
bb58083
new lint: `while_pop_unwrap`
y21 Apr 4, 2023
bcdcc34
elide lifetimes, get rid of glob import
y21 Apr 15, 2023
1d08325
move lint to loops, emit proper suggestion, more tests
y21 Apr 17, 2023
ab9b7a5
remove unnecessary reference
y21 Apr 17, 2023
f10e39f
make PopStmt copy+clone
y21 Apr 17, 2023
8d8178f
rename lint to `manual_while_let_some`
y21 Apr 19, 2023
9613ea8
fix run-rustfix directive
y21 Apr 29, 2023
7bc3da9
Auto merge of #10647 - y21:while_pop_unwrap, r=llogiq
bors Apr 29, 2023
032bc11
fix diagnostic message style
Icxolu Apr 29, 2023
de4bc66
Merge from rustc
RalfJung Apr 30, 2023
d4baabe
clean up Colon from clippy
chenyukang Mar 14, 2023
5749054
globally ignore `#[no_std]` crates
blyxyas May 1, 2023
8354b34
Auto merge of #111036 - RalfJung:miri, r=RalfJung
bors May 1, 2023
220a9db
fixed span and corrected test output
Icxolu May 1, 2023
824f2e7
Auto merge of #10724 - lukaslueg:largeerrdocs, r=giraffate
bors May 2, 2023
eac589b
Rollup merge of #110955 - fee1-dead-contrib:sus-operation, r=compiler…
Dylan-DPC May 2, 2023
d36bde7
Auto merge of #109128 - chenyukang:yukang/remove-type-ascription, r=e…
bors May 2, 2023
0dd2501
Don't ignore `check_radians`
blyxyas May 2, 2023
431cce1
Restrict `From<S>` for `{D,Subd}iagnosticMessage`.
nnethercote Apr 20, 2023
7e24ff3
Update macros.rs
smoelius May 2, 2023
9353170
Auto merge of #10730 - blyxyas:no_std_mul_add, r=Jarcho
bors May 3, 2023
c2e0d43
Auto merge of #10734 - smoelius:patch-2, r=Alexendoo
bors May 3, 2023
4e04903
rename to plural form
Icxolu May 3, 2023
8701009
add more test cases
Icxolu May 3, 2023
4ed7fd1
fix failing tests
Icxolu May 3, 2023
1603715
add `rustfix` annotation
Icxolu May 3, 2023
48ae5a0
fix lint docs
Icxolu May 3, 2023
f9c1d15
Auto merge of #10716 - Icxolu:unitstruct_default_construction, r=Mani…
bors May 3, 2023
8518391
Auto merge of #110806 - WaffleLapkin:unmkI, r=lcnr
bors May 4, 2023
0f7b61d
Inherit stdout/stderr for `cargo dev dogfood`
Alexendoo May 5, 2023
d7173e2
Auto merge of #10747 - Alexendoo:cargo-dev-dogfood-stdout, r=flip1995
bors May 5, 2023
88c7632
Merge remote-tracking branch 'upstream/master' into rustup
flip1995 May 5, 2023
79656cc
Bump nightly version -> 2023-05-05
flip1995 May 5, 2023
371120b
Auto merge of #10749 - flip1995:rustup, r=flip1995
bors May 5, 2023
4cb0519
Merge commit '371120bdbf58a331db5dcfb2d9cddc040f486de8' into clippyup
flip1995 May 5, 2023
b53c1bb
Update Cargo.lock
flip1995 May 5, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/ui/macro_use_imports.fixed
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ extern crate macro_use_helper as mac;
extern crate proc_macro_derive as mini_mac;

mod a {
use mac::{pub_macro, function_macro, ty_macro, inner_mod_macro, pub_in_private_macro};
use mac::{pub_macro, inner_mod_macro, function_macro, ty_macro, pub_in_private_macro};
use mac;
use mini_mac::ClippyMiniMacroTest;
use mini_mac;
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/macro_use_imports.stderr
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ error: `macro_use` attributes are no longer needed in the Rust 2018 edition
--> $DIR/macro_use_imports.rs:19:5
|
LL | #[macro_use]
| ^^^^^^^^^^^^ help: remove the attribute and import the macro directly, try: `use mac::{pub_macro, function_macro, ty_macro, inner_mod_macro, pub_in_private_macro};`
| ^^^^^^^^^^^^ help: remove the attribute and import the macro directly, try: `use mac::{pub_macro, inner_mod_macro, function_macro, ty_macro, pub_in_private_macro};`

error: aborting due to 4 previous errors