-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add experimental code to measure reference compile time regression for slice::sort #108662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental code to measure reference compile time regression for slice::sort #108662
Conversation
…r slice::sort This is only meant as an experiment, not to be merged. The regression data this yields should help get a better grip on the impact of `slice::sort` on compile times. This is helpful information for further work.
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@thomcc could you please start a timer run. @orlp and I want to use this data to get a better understanding of the impact this has on compiler perf. The important metric being how much extra work does it have to do to compile more code, not how much faster is sort. Because for both stable and unstable sort, the compiler spends less than 0.1% in each, so these are not responsible for the slowdown. |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
⌛ Trying commit 6aeebad with merge ba11738028df315432b532791e29abc7c781ba02... |
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (ba11738028df315432b532791e29abc7c781ba02): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
The experiment was performed and the results gathered. |
This is only meant as an experiment, not to be merged. The regression data this yields should help get a better grip on the impact of
slice::sort
on compile times. This is helpful information for further work.DO NOT MERGE THIS