Skip to content

Rollup of 6 pull requests #108211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 18, 2023
Merged

Rollup of 6 pull requests #108211

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
380fa26
Don't recover lifetimes/labels containing emojis as character literals
jieyouxu Feb 14, 2023
98b82ae
Update numeric lifetime test
jieyouxu Feb 14, 2023
e3f9db5
Update lexer lifetime test
jieyouxu Feb 14, 2023
eebd31c
Don't eagerly convert principal to string
clubby789 Feb 17, 2023
b4182d2
Don't allow evaluating queries that were fed in a previous compiler run
oli-obk Feb 14, 2023
55a7915
Update cargo
weihanglo Feb 17, 2023
fded2e9
Adjust tracking issue for non_lifetime_binders
compiler-errors Feb 17, 2023
cec7835
Move late-bound arg type checks to resolve_bound_vars
compiler-errors Feb 18, 2023
5ec812d
Add addl test
compiler-errors Feb 18, 2023
225e01e
link to llvm changes that prompted the special cases
tshepang Feb 18, 2023
8ab795e
add a summary, in addition to the link
tshepang Feb 18, 2023
3035ccb
Rollup merge of #108031 - jieyouxu:issue-108019, r=estebank
matthiaskrgr Feb 18, 2023
d9c9040
Rollup merge of #108046 - oli-obk:no_evaluating_fed_queries, r=cjgillot
matthiaskrgr Feb 18, 2023
7f9d9de
Rollup merge of #108162 - clubby789:issue-108155, r=Nilstrieb
matthiaskrgr Feb 18, 2023
d3d5163
Rollup merge of #108186 - compiler-errors:closures-with-late-bound-ty…
matthiaskrgr Feb 18, 2023
5d5e0b0
Rollup merge of #108197 - weihanglo:update-cargo, r=weihanglo
matthiaskrgr Feb 18, 2023
6c91efd
Rollup merge of #108205 - tshepang:why-special-case, r=cjgillot
matthiaskrgr Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust tracking issue for non_lifetime_binders
  • Loading branch information
@compiler-errors
compiler-errors committed Feb 18, 2023
commit fded2e95abac4bffcd4dedfff93a34520aa91be2
2 changes: 1 addition & 1 deletion compiler/rustc_feature/src/active.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ declare_features! (
/// Allows using the `non_exhaustive_omitted_patterns` lint.
(active, non_exhaustive_omitted_patterns_lint, "1.57.0", Some(89554), None),
/// Allows `for<T>` binders in where-clauses
(incomplete, non_lifetime_binders, "CURRENT_RUSTC_VERSION", Some(1), None),
(incomplete, non_lifetime_binders, "CURRENT_RUSTC_VERSION", Some(108185), None),
/// Allows making `dyn Trait` well-formed even if `Trait` is not object safe.
/// In that case, `dyn Trait: Trait` does not hold. Moreover, coercions and
/// casts in safe Rust to `dyn Trait` for such a `Trait` is also forbidden.
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/bounds-lifetime.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | type D = for<'a, T> fn();
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error[E0658]: only lifetime parameters can be used in this context
Expand All @@ -31,7 +31,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | type E = dyn for<T> Fn();
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to 5 previous errors
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/closures/binder/disallow-const.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | for<const N: i32> || -> () {};
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to previous error
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/closures/binder/disallow-ty.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | for<T> || -> () {};
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to previous error
Expand Down
6 changes: 3 additions & 3 deletions tests/ui/conditional-compilation/cfg-generic-params.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | type FnBad = for<#[cfg(no)] 'a, #[cfg(yes)] T> fn();
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error[E0658]: only lifetime parameters can be used in this context
Expand All @@ -43,7 +43,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | type PolyBad = dyn for<#[cfg(no)] 'a, #[cfg(yes)] T> Copy;
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error[E0658]: only lifetime parameters can be used in this context
Expand All @@ -52,7 +52,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | struct WhereBad where for<#[cfg(no)] 'a, #[cfg(yes)] T> u8: Copy;
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to 8 previous errors
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/feature-gates/feature-gate-non_lifetime_binders.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | fn foo() where for<T> T:, {}
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to previous error
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/higher-rank-trait-bounds/hrtb-wrong-kind.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | fn a() where for<T> T: Copy {}
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error[E0658]: only lifetime parameters can be used in this context
Expand All @@ -13,7 +13,7 @@ error[E0658]: only lifetime parameters can be used in this context
LL | fn b() where for<const C: usize> [(); C]: Copy {}
| ^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= help: add `#![feature(non_lifetime_binders)]` to the crate attributes to enable

error: aborting due to 2 previous errors
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/traits/non_lifetime_binders/basic.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ warning: the feature `non_lifetime_binders` is incomplete and may not be safe to
LL | #![feature(non_lifetime_binders)]
| ^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= note: `#[warn(incomplete_features)]` on by default

warning: 1 warning emitted
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/traits/non_lifetime_binders/fail.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ warning: the feature `non_lifetime_binders` is incomplete and may not be safe to
LL | #![feature(non_lifetime_binders)]
| ^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= note: `#[warn(incomplete_features)]` on by default

error[E0277]: the trait bound `T: Trait` is not satisfied
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/traits/non_lifetime_binders/on-dyn.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ warning: the feature `non_lifetime_binders` is incomplete and may not be safe to
LL | #![feature(non_lifetime_binders)]
| ^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= note: `#[warn(incomplete_features)]` on by default

error: late-bound type parameter not allowed on trait object types
Expand Down
2 changes: 1 addition & 1 deletion tests/ui/traits/non_lifetime_binders/on-ptr.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ warning: the feature `non_lifetime_binders` is incomplete and may not be safe to
LL | #![feature(non_lifetime_binders)]
| ^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #1 <https://github.com/rust-lang/rust/issues/1> for more information
= note: see issue #108185 <https://github.com/rust-lang/rust/issues/108185> for more information
= note: `#[warn(incomplete_features)]` on by default

error: late-bound type parameter not allowed on function pointer types
Expand Down