Skip to content

Conversation

@notriddle
Copy link
Contributor

This keeps the line height for body text the same, as required by WCAG, but for headers, it makes sense to have wrapped lines be a bit tighter packed.

Before

image

After

image

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 12, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 12, 2023

📌 Commit b0df355 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107748 (refer to new home)
 - rust-lang#107842 (Patch `build/rustfmt/lib/*.so` for NixOS)
 - rust-lang#107930 (Improve JS function itemTypeFromName code a bit)
 - rust-lang#107934 (rustdoc: account for intra-doc links in `<meta name="description">`)
 - rust-lang#107943 (Document `PointerLike`)
 - rust-lang#107954 (avoid mixing accesses of ptrs derived from a mutable ref and parent ptrs)
 - rust-lang#107955 (fix UB in ancient test)
 - rust-lang#107964 (rustdoc: use tighter line height in h1 and h2)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1d4397b into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@notriddle notriddle deleted the notriddle/title-line-height branch February 13, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants