Skip to content

rustc_ast: Merge impls and reorder methods for attributes and meta items #107935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

rustc_ast: Merge impls and reorder methods for attributes and meta items #107935

merged 1 commit into from
Feb 13, 2023

Conversation

@petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Feb 11, 2023

Merge impl blocks for the same types, change order of methods to be more predictable and consistent between impls.
No functional changes.
Follow up to #107569.

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2023

r? @michaelwoerister

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 11, 2023
@michaelwoerister
Copy link
Member

michaelwoerister commented Feb 13, 2023

Thanks, @petrochenkov!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 13, 2023

📌 Commit 37a72a2 has been approved by michaelwoerister

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 13, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 13, 2023
@bors
Auto merge of rust-lang#107989 - matthiaskrgr:rollup-jklrd5g, r=matth…
0b439b1 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#107340 (rustdoc: merge doctest tooltip with notable traits tooltip)
 - rust-lang#107838 (Introduce `-Zterminal-urls` to use OSC8 for error codes)
 - rust-lang#107922 (Print disk usage in PGO CI script)
 - rust-lang#107931 (Intern span when length is MAX_LEN with parent.)
 - rust-lang#107935 (rustc_ast: Merge impls and reorder methods for attributes and meta items)
 - rust-lang#107986 (layout: deal with placeholders, ICE on bound types)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 99d36b1 into rust-lang:master Feb 13, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 13, 2023
@petrochenkov petrochenkov deleted the attreorder branch February 22, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@michaelwoerister michaelwoerister

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.69.0

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov @rustbot @michaelwoerister @bors