Skip to content

Conversation

@cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Feb 9, 2023

Fixes #107818

@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2023

r? @nagisa

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 9, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk
Copy link
Contributor

oli-obk commented Feb 10, 2023

r? @oli-obk

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 10, 2023

📌 Commit 221ea30 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2023
@matthiaskrgr
Copy link
Member

@bors rollup=never
bumping this up in the queue

@bors
Copy link
Collaborator

bors commented Feb 11, 2023

⌛ Testing commit 221ea30 with merge 585f3ee...

@bors
Copy link
Collaborator

bors commented Feb 11, 2023

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 585f3ee to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 11, 2023
@bors bors merged commit 585f3ee into rust-lang:master Feb 11, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 11, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (585f3ee): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.3% [1.1%, 3.5%] 3
Regressions ❌
(secondary)
1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)
-2.3% [-3.3%, -1.3%] 3
Improvements ✅
(secondary)
-2.7% [-3.0%, -2.3%] 3
All ❌✅ (primary) 0.0% [-3.3%, 3.5%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [2.1%, 2.1%] 1
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.1% [2.1%, 2.1%] 1

@cjgillot cjgillot deleted the sroa-const branch February 12, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UB: matching on const value with mir-opt-level=3

7 participants