Skip to content

Use id-based thread parking on SOLID #106372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

Use id-based thread parking on SOLID #106372

merged 1 commit into from
Feb 16, 2023

Conversation

joboet
Copy link
Member

@joboet joboet commented Jan 2, 2023

By using the slp_tsk/wup_tsk system functions instead of an event-flag structure, Parker becomes cheaper to construct and SOLID can share the implementation used by NetBSD and SGX.

ping @kawadakk
r? @m-ou-se
@rustbot label +T-libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@m-ou-se
Copy link
Member

m-ou-se commented Feb 13, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 13, 2023

📌 Commit 7824528 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Feb 14, 2023
@Dylan-DPC
Rollup merge of rust-lang#106372 - joboet:solid_id_parking, r=m-ou-se
6f88493 
Use id-based thread parking on SOLID

By using the [`slp_tsk`/`wup_tsk`](https://cs.uwaterloo.ca/~brecht/courses/702/Possible-Readings/embedded/uITRON-4.0-specification.pdf) system functions instead of an event-flag structure, `Parker` becomes cheaper to construct and SOLID can share the implementation used by NetBSD and SGX.

ping `@kawadakk`
r? `@m-ou-se`
`@rustbot` label +T-libs
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 14, 2023
Closed
@Dylan-DPC Dylan-DPC mentioned this pull request Feb 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2023
@bors
Auto merge of rust-lang#108116 - Dylan-DPC:rollup-h3n2vxl, r=Dylan-DPC
4b34c7b 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#106372 (Use id-based thread parking on SOLID)
 - rust-lang#108050 (Fix index out of bounds ICE in `point_at_expr_source_of_inferred_type`)
 - rust-lang#108084 (Constify `RangeBounds`, `RangeX::contains` and `RangeX::is_empty` (where applicable).)
 - rust-lang#108101 (don't clone types that are copy)
 - rust-lang#108102 (simplify some refs)
 - rust-lang#108103 (be nice and don't slice)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0c5bbca into rust-lang:master Feb 16, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 16, 2023
@joboet joboet deleted the solid_id_parking branch February 16, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kawadakk kawadakk kawadakk approved these changes

Assignees

@m-ou-se m-ou-se

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joboet @rustbot @m-ou-se @bors @kawadakk