Skip to content

Add comment explaining what docblock-table GUI test is about #106350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 1, 2023
Merged

Add comment explaining what docblock-table GUI test is about #106350

merged 1 commit into from
Jan 1, 2023

Conversation

GuillaumeGomez
Copy link
Member

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 1, 2023
@GuillaumeGomez GuillaumeGomez force-pushed the gui-test-explanation-2 branch from 3d88889 to d14e636 Compare January 1, 2023 16:22
@GuillaumeGomez GuillaumeGomez changed the title Add comment explanaining what docblock-table GUI test is about Add comment explaining what docblock-table GUI test is about Jan 1, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 1, 2023

📌 Commit d14e636 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2023
@bors
Copy link
Collaborator

bors commented Jan 1, 2023

⌛ Testing commit d14e636 with merge 7742995...

@bors
Copy link
Collaborator

bors commented Jan 1, 2023

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing 7742995 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2023
@bors bors merged commit 7742995 into rust-lang:master Jan 1, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 1, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7742995): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@GuillaumeGomez GuillaumeGomez deleted the gui-test-explanation-2 branch January 2, 2023 10:05
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#106350 - GuillaumeGomez:gui-test-explanation-…
fc98751 
…2, r=notriddle

Add comment explaining what docblock-table GUI test is about

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@notriddle notriddle

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @notriddle @bors @rust-timer @rustbot