Help rust-analyzer normalize query return types #105493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? Nilstrieb A little sad that we can't use them, but query return types are pretty important and should work in RA. CI shouldn't fail since you just added a comment but just in case, r=me once CI is green @bors rollup |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 17, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#105493 (Help rust-analyzer normalize query return types) - rust-lang#105710 (Don't bug if we're trying to cast `dyn*` to another type) - rust-lang#105711 (bail in `collect_trait_impl_trait_tys` if signatures reference errors) - rust-lang#105768 (Detect inherent associated types not having CamelCase) - rust-lang#105780 (rustdoc: Don't add "Read more" link if there is no extra content) - rust-lang#105802 (Make enum-match.rs test robust against variable name changes) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zulip thread, since #103808, rust analyzer doesn't normalize return types of queries. This is because r-a doesn't support associated type defaults (yet).
The easiest fix is to not use associated type defaults (duh), which this PR does.
r? @cjgillot