rustdoc: remove no-op CSS #main-content > .item-info { margin-top: 0 }
#103940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this line was added in 04b4c40, it overrode a negative `margin-top` that was set on it by default. https://github.com/rust-lang/rust/blob/04b4c40682c01cad8f9bc8d5b3907be91d6f81d4/src/librustdoc/html/static/rustdoc.css#L500-L516 That negative top margin was removed in 593d6d1.
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Nov 3, 2022
|
Thanks! r=me once CI pass |
|
@bors r=GuillaumeGomez rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 4, 2022
…iaskrgr Rollup of 10 pull requests Successful merges: - rust-lang#103825 (Remove let_underscore_must_use from list of uplifted lints) - rust-lang#103884 (Add visit_fn_ret_ty to hir intravisit) - rust-lang#103892 (Properly render asyncness for trait fns without default body) - rust-lang#103905 (rustdoc: remove redundant mobile CSS `.sidebar-elems { background }`) - rust-lang#103912 (Add howto for adding new targets) - rust-lang#103915 (Improve use of ErrorGuaranteed and code cleanup) - rust-lang#103930 (Move some tests from `src/test/ui` to more reasonable places) - rust-lang#103931 (Add note to RELEASES.md regarding issue 102754.) - rust-lang#103938 (rustdoc: clean up hardcoded CSS border color on search results) - rust-lang#103940 (rustdoc: remove no-op CSS `#main-content > .item-info { margin-top: 0 }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this line was added in 04b4c40, it overrode a negative
margin-topthat was set on it by default.rust/src/librustdoc/html/static/rustdoc.css
Lines 500 to 516 in 04b4c40
That negative top margin was removed in 593d6d1.