Skip to content

Rollup of 5 pull requests #103841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Nov 1, 2022
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
6afd0f5
Refactor: unwrap `Option` once in the beginning of closure
lowr Oct 24, 2022
6a00e14
fix: Don't respond with an error when requesting a shutdown while sta…
Veykril Oct 24, 2022
98aa678
Auto merge of #13476 - Veykril:prefer-shutdown, r=Veykril
bors Oct 24, 2022
fbae83a
fix: Fix standard flycheck command not being executed in the workspac…
Veykril Oct 24, 2022
53b6d69
Auto merge of #13478 - Veykril:fix-flycheck, r=Veykril
bors Oct 24, 2022
15d4383
Let `InferenceTable::unify()` relate `Zip` values
lowr Oct 24, 2022
7d82cad
Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error
Aaron1011 Oct 5, 2022
956b96a
Switch to upstream positionEncoding
lnicola Oct 25, 2022
e93a2bf
Pin lsp-types
lnicola Oct 25, 2022
67f1d8f
Test all generic args for trait when finding matching impl
lowr Oct 25, 2022
feefbe7
Auto merge of #13475 - lowr:fix/lookup-impl-method-trait-ref, r=flodi…
bors Oct 26, 2022
0340b51
Auto merge of #13484 - lnicola:position-encoding, r=lnicola
bors Oct 26, 2022
1fe10bf
refactor: remove obsolete code
lowr Oct 26, 2022
4dd6943
Display generic arguments for associated types
lowr Oct 27, 2022
f233ac4
Lower generic arguments for associated types in paths
lowr Oct 26, 2022
63cba43
Collect generic arguments in associated type bindings
lowr Oct 26, 2022
5fc18ad
Lower generic arguments for GATs in associated type bindings
lowr Oct 27, 2022
c6e1e17
Auto merge of #13494 - lowr:feat/gats, r=flodiebold
bors Oct 27, 2022
05514d8
Clarify feature policy
lnicola Oct 27, 2022
d022e0e
Auto merge of #13496 - rust-lang:lnicola-patch-1, r=jonas-schievink
bors Oct 27, 2022
5c79421
Replace expect test for GATs with `check_types`
lowr Oct 28, 2022
e0f09cd
Document the ordering constraint on `Binders` and `Substitution`
lowr Oct 28, 2022
274df54
feat: Clicking the status bar item stops and starts the server
Veykril Oct 28, 2022
e69014a
Auto merge of #13510 - Veykril:status-click, r=Veykril
bors Oct 28, 2022
2071d00
Always set up VSCode commands
Veykril Oct 28, 2022
7610ee9
Auto merge of #13512 - Veykril:startup-commands, r=Veykril
bors Oct 28, 2022
fccf8eb
Properly handle vscode workspace changes
Veykril Oct 28, 2022
ebce5e9
Auto merge of #13513 - Veykril:vscode-workspace-changes, r=Veykril
bors Oct 28, 2022
ba28e19
Auto merge of #13505 - lowr:feat/gats, r=flodiebold
bors Oct 29, 2022
637bfe6
resolve: Not all imports have their own `NodeId`
petrochenkov Oct 30, 2022
8431751
resolve: Turn the binding from `#[macro_export]` into a proper `Import`
petrochenkov Oct 30, 2022
5e64804
rustdoc: remove unnecessary CSS `.search-results { clear: both }`
notriddle Oct 31, 2022
6432bb7
rustdoc: rename syntax highlighting CSS class `attribute` to `attr`
notriddle Oct 31, 2022
0b3e75e
:arrow_up: rust-analyzer
lnicola Nov 1, 2022
9f603fe
Rollup merge of #84022 - Aaron1011:remove-derive-res-fallback, r=petr…
Dylan-DPC Nov 1, 2022
68afa32
Rollup merge of #103760 - petrochenkov:macimp, r=cjgillot
Dylan-DPC Nov 1, 2022
db200d0
Rollup merge of #103813 - notriddle:notriddle/search-results-clear-bo…
Dylan-DPC Nov 1, 2022
2b0ead3
Rollup merge of #103817 - notriddle:notriddle/attribute-css, r=Guilla…
Dylan-DPC Nov 1, 2022
2b10891
Rollup merge of #103833 - lnicola:rust-analyzer-2022-11-01, r=lnicola
Dylan-DPC Nov 1, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/librustdoc/html/highlight.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ impl Class {
match self {
Class::Comment => "comment",
Class::DocComment => "doccomment",
Class::Attribute => "attribute",
Class::Attribute => "attr",
Class::KeyWord => "kw",
Class::RefKeyWord => "kw-2",
Class::Self_(_) => "self",
Expand Down
8 changes: 4 additions & 4 deletions src/librustdoc/html/highlight/fixtures/sample.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,16 @@
.kw { color: #8959A8; }
.kw-2, .prelude-ty { color: #4271AE; }
.number, .string { color: #718C00; }
.self, .bool-val, .prelude-val, .attribute, .attribute .ident { color: #C82829; }
.self, .bool-val, .prelude-val, .attr, .attr .ident { color: #C82829; }
.macro, .macro-nonterminal { color: #3E999F; }
.lifetime { color: #B76514; }
.question-mark { color: #ff9011; }
</style>
<pre><code><span class="attribute">#![crate_type = <span class="string">&quot;lib&quot;</span>]
<pre><code><span class="attr">#![crate_type = <span class="string">&quot;lib&quot;</span>]

</span><span class="kw">use </span>std::path::{Path, PathBuf};

<span class="attribute">#[cfg(target_os = <span class="string">&quot;linux&quot;</span>)]
<span class="attr">#[cfg(target_os = <span class="string">&quot;linux&quot;</span>)]
#[cfg(target_os = <span class="string">&quot;windows&quot;</span>)]
</span><span class="kw">fn </span>main() -&gt; () {
<span class="kw">let </span>foo = <span class="bool-val">true </span>&amp;&amp; <span class="bool-val">false </span>|| <span class="bool-val">true</span>;
Expand All @@ -23,7 +23,7 @@
<span class="macro">mac!</span>(foo, <span class="kw-2">&amp;mut </span>bar);
<span class="macro">assert!</span>(<span class="self">self</span>.length &lt; N &amp;&amp; index &lt;= <span class="self">self</span>.length);
::std::env::var(<span class="string">&quot;gateau&quot;</span>).is_ok();
<span class="attribute">#[rustfmt::skip]
<span class="attr">#[rustfmt::skip]
</span><span class="kw">let </span>s:std::path::PathBuf = std::path::PathBuf::new();
<span class="kw">let </span><span class="kw-2">mut </span>s = String::new();

Expand Down
2 changes: 1 addition & 1 deletion src/librustdoc/html/highlight/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const STYLE: &str = r#"
.kw { color: #8959A8; }
.kw-2, .prelude-ty { color: #4271AE; }
.number, .string { color: #718C00; }
.self, .bool-val, .prelude-val, .attribute, .attribute .ident { color: #C82829; }
.self, .bool-val, .prelude-val, .attr, .attr .ident { color: #C82829; }
.macro, .macro-nonterminal { color: #3E999F; }
.lifetime { color: #B76514; }
.question-mark { color: #ff9011; }
Expand Down
2 changes: 1 addition & 1 deletion src/librustdoc/html/static/css/rustdoc.css
Original file line number Diff line number Diff line change
Expand Up @@ -1090,7 +1090,7 @@ pre.rust .bool-val {
pre.rust .self {
color: var(--code-highlight-self-color);
}
pre.rust .attribute {
pre.rust .attr {
color: var(--code-highlight-attribute-color);
}
pre.rust .macro,
Expand Down
10 changes: 5 additions & 5 deletions src/test/rustdoc-gui/highlight-colors.goml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ define-function: (
string,
bool_val,
self,
attribute,
attr,
macro,
question_mark,
comment,
Expand All @@ -33,7 +33,7 @@ define-function: (
("assert-css", ("pre.rust .string", {"color": |string|}, ALL)),
("assert-css", ("pre.rust .bool-val", {"color": |bool_val|}, ALL)),
("assert-css", ("pre.rust .self", {"color": |self|}, ALL)),
("assert-css", ("pre.rust .attribute", {"color": |attribute|}, ALL)),
("assert-css", ("pre.rust .attr", {"color": |attr|}, ALL)),
("assert-css", ("pre.rust .macro", {"color": |macro|}, ALL)),
("assert-css", ("pre.rust .question-mark", {"color": |question_mark|}, ALL)),
("assert-css", ("pre.rust .comment", {"color": |comment|}, ALL)),
Expand All @@ -52,7 +52,7 @@ call-function: ("check-colors", {
"string": "rgb(184, 204, 82)",
"bool_val": "rgb(255, 119, 51)",
"self": "rgb(54, 163, 217)",
"attribute": "rgb(230, 225, 207)",
"attr": "rgb(230, 225, 207)",
"macro": "rgb(163, 122, 204)",
"question_mark": "rgb(255, 144, 17)",
"comment": "rgb(120, 135, 151)",
Expand All @@ -69,7 +69,7 @@ call-function: ("check-colors", {
"string": "rgb(131, 163, 0)",
"bool_val": "rgb(238, 104, 104)",
"self": "rgb(238, 104, 104)",
"attribute": "rgb(238, 104, 104)",
"attr": "rgb(238, 104, 104)",
"macro": "rgb(62, 153, 159)",
"question_mark": "rgb(255, 144, 17)",
"comment": "rgb(141, 141, 139)",
Expand All @@ -86,7 +86,7 @@ call-function: ("check-colors", {
"string": "rgb(113, 140, 0)",
"bool_val": "rgb(200, 40, 41)",
"self": "rgb(200, 40, 41)",
"attribute": "rgb(200, 40, 41)",
"attr": "rgb(200, 40, 41)",
"macro": "rgb(62, 153, 159)",
"question_mark": "rgb(255, 144, 17)",
"comment": "rgb(142, 144, 140)",
Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-41783.codeblock.html
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<code># single
## double
### triple
<span class="attribute">#[outer]
<span class="attr">#[outer]
#![inner]</span></code>
6 changes: 3 additions & 3 deletions src/test/rustdoc/issue-41783.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
// @has issue_41783/struct.Foo.html
// @!hasraw - 'space'
// @!hasraw - 'comment'
// @hasraw - '<span class="attribute">#[outer]'
// @!hasraw - '<span class="attribute">#[outer]</span>'
// @hasraw - '<span class="attr">#[outer]'
// @!hasraw - '<span class="attr">#[outer]</span>'
// @hasraw - '#![inner]</span>'
// @!hasraw - '<span class="attribute">#![inner]</span>'
// @!hasraw - '<span class="attr">#![inner]</span>'
// @snapshot 'codeblock' - '//*[@class="rustdoc-toggle top-doc"]/*[@class="docblock"]//pre/code'

/// ```no_run
Expand Down