Skip to content

Rollup of 9 pull requests #103375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 22, 2022
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a5e116e
`order_dependent_trait_objects` to `ReportNow`
lcnr Oct 3, 2022
cc6ad45
replaced wrong test with the correct mcve
SarthakSingh31 Oct 21, 2022
62a2a1d
fix some typos
Rageking8 Oct 21, 2022
3ff0a33
WinConsole::new is not actually fallible
RalfJung Oct 21, 2022
353ef69
add test for issue 97607
Rageking8 Oct 21, 2022
349ba6b
Remove needless special cases and dead code
oli-obk Oct 21, 2022
d6cf893
Require Drop impls to have the same constness on its bounds as the bo…
oli-obk Oct 21, 2022
e97d295
Remove incorrect comment in `Vec::drain`
WaffleLapkin Oct 21, 2022
0dbf233
rustdoc: merge identical CSS blocks
notriddle Oct 21, 2022
526c1d3
rustdoc: prevent method summary margin from being applied to docblocks
notriddle Oct 21, 2022
1adb4c3
rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`
notriddle Oct 21, 2022
ebfdf73
Rollup merge of #102635 - lcnr:incoherent_auto_trait_objects, r=jackh726
matthiaskrgr Oct 21, 2022
e67f09a
Rollup merge of #103335 - SarthakSingh31:issue-89008, r=jackh726
matthiaskrgr Oct 21, 2022
7ee0aea
Rollup merge of #103339 - Rageking8:fix-some-typos, r=fee1-dead
matthiaskrgr Oct 21, 2022
b21eb5e
Rollup merge of #103340 - RalfJung:winconsole, r=thomcc
matthiaskrgr Oct 21, 2022
db4696a
Rollup merge of #103341 - Rageking8:add-test-for-issue-97607, r=compi…
matthiaskrgr Oct 21, 2022
ed430ca
Rollup merge of #103351 - oli-obk:tilde_const_impls, r=fee1-dead
matthiaskrgr Oct 21, 2022
1b2f594
Rollup merge of #103359 - WaffleLapkin:drain_no_mut_qqq, r=scottmcm
matthiaskrgr Oct 21, 2022
66f33df
Rollup merge of #103364 - notriddle:notriddle/toggles, r=jsha
matthiaskrgr Oct 21, 2022
1d3aa7b
Rollup merge of #103370 - notriddle:notriddle/out-of-band, r=Guillaum…
matthiaskrgr Oct 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove incorrect comment in Vec::drain
  • Loading branch information
WaffleLapkin committed Oct 21, 2022
commit e97d295d0078b03212cecb91854b979e4757ba72
4 changes: 1 addition & 3 deletions library/alloc/src/vec/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1999,9 +1999,7 @@ impl<T, A: Allocator> Vec<T, A> {
unsafe {
// set self.vec length's to start, to be safe in case Drain is leaked
self.set_len(start);
// Use the borrow in the IterMut to indicate borrowing behavior of the
// whole Drain iterator (like &mut T).
let range_slice = slice::from_raw_parts_mut(self.as_mut_ptr().add(start), end - start);
let range_slice = slice::from_raw_parts(self.as_ptr().add(start), end - start);
Drain {
tail_start: end,
tail_len: len - end,
Expand Down